Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup tests in services #32

Closed
13 tasks done
wmnsk opened this issue Sep 3, 2018 · 0 comments
Closed
13 tasks done

Cleanup tests in services #32

wmnsk opened this issue Sep 3, 2018 · 0 comments
Assignees
@wmnsk
Labels
quality
Projects
First Release

Comments

@wmnsk
Copy link
Collaborator

wmnsk commented Sep 3, 2018 •
edited
Loading

Now the tests for each service in service_test.go is becoming too big. Need to split tests for each service and write more efficient tests.

  • OpenSecureChannelRequest
  • OpenSecureChannelResponse
  • CloseSecureChannelRequest
  • CloseSecureChannelResponse
  • GetEndpointsRequest
  • GetEndpointsResponse
  • CreateSessionRequest
  • CreateSessionResponse
  • ActivateSessionRequest
  • ActivateSessionResponse
  • CloseSessionRequest
  • CloseSessionResponse
  • ReadRequest
@wmnsk wmnsk added the quality label Sep 14, 2018
@wmnsk wmnsk added this to To do in First Release Sep 14, 2018
@wmnsk wmnsk mentioned this issue Sep 15, 2018
Merged
@wmnsk wmnsk moved this from To do to In progress in First Release Sep 15, 2018
@wmnsk wmnsk self-assigned this Sep 16, 2018
wmnsk added a commit that referenced this issue Oct 1, 2018
@wmnsk
cleanup tests in services and revised header handling in services, fixes
a358d1e 
 #32 and #82
@wmnsk wmnsk mentioned this issue Oct 1, 2018
Merged
@wmnsk wmnsk closed this as completed in 33c5219 Oct 1, 2018
@wmnsk wmnsk moved this from In progress to Done in First Release Oct 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wmnsk wmnsk

Labels
quality
Projects
No open projects
First Release
  
Done
Milestone
No milestone
Development

No branches or pull requests
1 participant
@wmnsk