Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change Request/ResponseHeader handling in constructors of service #82

Closed
wmnsk opened this issue Oct 1, 2018 · 1 comment
Closed

Change Request/ResponseHeader handling in constructors of service #82

wmnsk opened this issue Oct 1, 2018 · 1 comment
Assignees
Labels

Comments

@wmnsk
Copy link
Collaborator

wmnsk commented Oct 1, 2018

In the current implementation, params inside RequestHeader in each service is given respectively, but it should be given with *RequestHeader to be more flexible and consice in handling services with constructor.

For example,

func NewActivateSessionRequest(ts time.Time, authToken datatypes.NodeID, handle, diag, timeout uint32, auditID string, sig *SignatureData, certs []*SignedSoftwareCertificate, locales []string, userToken *datatypes.ExtensionObject, tokenSig *SignatureData) *ActivateSessionRequest {

should be;

func NewActivateSessionRequest(reqHeader *RequestHeader, sig *SignatureData, certs []*SignedSoftwareCertificate, locales []string, userToken *datatypes.ExtensionObject, tokenSig *SignatureData) *ActivateSessionRequest {
@wmnsk wmnsk added the quality label Oct 1, 2018
@wmnsk wmnsk added this to To do in First Release Oct 1, 2018
@wmnsk wmnsk moved this from To do to In progress in First Release Oct 1, 2018
@wmnsk wmnsk changed the title Change RequestHeader handling in constructors of service Change Request/ResponseHeader handling in constructors of service Oct 1, 2018
@wmnsk wmnsk self-assigned this Oct 1, 2018
@wmnsk
Copy link
Collaborator Author

wmnsk commented Oct 1, 2018

Fixed in 33c5219 / PR#84

@wmnsk wmnsk closed this as completed Oct 1, 2018
@wmnsk wmnsk moved this from In progress to Done in First Release Oct 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
First Release
  
Done
Development

No branches or pull requests

1 participant