Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Router] Shorter refs? #160

Closed
Shikkic opened this issue Sep 13, 2016 · 4 comments
Closed

[Router] Shorter refs? #160

Shikkic opened this issue Sep 13, 2016 · 4 comments
Assignees

Comments

@Shikkic
Copy link
Member

Shikkic commented Sep 13, 2016

It would probably be better to have shortened refs if possible. Future optimization maybe? b5232bb...

@skeswa
Copy link
Contributor

skeswa commented Sep 14, 2016

Why is this in QA fam?

@Shikkic
Copy link
Member Author

Shikkic commented Sep 14, 2016

I thought you had a PR for it in the router? I might have been mistaken.

@skeswa
Copy link
Contributor

skeswa commented Sep 16, 2016

Nurp. That was for fully qualified SHAs. Starting this one presently. The mini-SHAs are only going to work for refs of branches, tags, PRs and heads btw.

@skeswa
Copy link
Contributor

skeswa commented Sep 20, 2016

Put this on hold while writing tests for the router and depot.

@Shikkic Shikkic assigned Shikkic and unassigned skeswa Sep 25, 2016
@skeswa skeswa closed this as completed Oct 30, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants