Skip to content
This repository has been archived by the owner on Sep 6, 2018. It is now read-only.

Snapshot issue #29

Closed
xiang90 opened this issue Jun 27, 2013 · 4 comments
Closed

Snapshot issue #29

xiang90 opened this issue Jun 27, 2013 · 4 comments
Milestone

Comments

@xiang90
Copy link
Contributor

xiang90 commented Jun 27, 2013

When the snapshot get large, to send the whole snapshot to a slow follower will not be a good idea.

Should we do incremental snapshot or keep the previous log for a longer time after the snapshot?

@benbjohnson
Copy link
Contributor

I think we should probably have a way to tweak how much of the log to keep around to prevent slow followers from having to grab a snapshot. I think incremental snapshots would be a pain to implement. Maintaining extra log entries is a lot easier.

@xiang90
Copy link
Contributor Author

xiang90 commented Jun 30, 2013

Yeah. Let me clean up the snapshot codes and think a way to decide how many previous log we should keep.

@philips
Copy link
Member

philips commented Jun 30, 2013

@xiangli-cmu Perhaps it should just be two or three compactions with a tunable for people who need it?

@xiang90
Copy link
Contributor Author

xiang90 commented Jul 22, 2013

We keep the recent NumberOfLogEntriesAfterSnapshot entries to alleviate this problem

@xiang90 xiang90 closed this as completed Jul 22, 2013
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants