Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicate export in @glyphs/wc-core #43

Closed
Hyzual opened this issue May 23, 2021 · 3 comments
Closed

Duplicate export in @glyphs/wc-core #43

Hyzual opened this issue May 23, 2021 · 3 comments
Labels
bug Something isn't working

Comments

@Hyzual
Copy link

Hyzual commented May 23, 2021

Hi, thanks for sharing this set of icons 🙂. I was looking to use it in my web components project, but unfortunately I stumbled upon a couple of issues.

First issue is that when I import @glyphs/wc-core, there is a "duplicate export" issue with CoreGrinBeam:

Duplicate export 'CoreGrinBeam' (741:20) in @glyphs/wc-core/src/index.js

See reproduction on codepen: https://codepen.io/hyzual/pen/wvJJLpG

I haven't figured out how the list is built but I can confirm there is a duplicate in node_modules/@glyphs/wc-core/src/index.js :

//L740-741
export { default as CoreGrinBeam } from './icons/GrinBeam'
export { default as CoreGrinBeam } from './icons/GrinBeam'

I would be grateful if you could please take a look at that issue 🙂, as without it I must find some creative workarounds to import each icon.

@Hyzual
Copy link
Author

Hyzual commented Jul 23, 2021

Any update ? 😕 I'm willing to help resolve this

@gorango gorango added the bug Something isn't working label Aug 12, 2021
@gorango
Copy link
Owner

gorango commented Aug 12, 2021

Hey there! Thanks for reporting and sorry for the delay.

Just resolved with 299cf30

However, the web component has some glaring issues which you aptly pointed out in #44. I am working on an overhaul to all of the components to reduce all logic to a single component as well as to leverage tree-shaking and importing SVGs only as needed.

@gorango gorango closed this as completed Aug 12, 2021
@Hyzual
Copy link
Author

Hyzual commented Aug 12, 2021

Thanks for the fix! No problem about the delay, I'm glad to have an answer 😄. I look forward to trying again, I'm a bit swamped too these days so I don't know when that will be. Thanks again for your time 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants