Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: deprecate buildpacks #2982

Merged
merged 6 commits into from
Mar 17, 2022
Merged

feat: deprecate buildpacks #2982

merged 6 commits into from
Mar 17, 2022

Conversation

caarlos0
Copy link
Member

@caarlos0 caarlos0 commented Mar 17, 2022 •
edited
Loading

closes #2976

@caarlos0
feat: deprecate buildpacks
438905f 
Signed-off-by: Carlos A Becker <caarlos0@gmail.com>
@caarlos0 caarlos0 self-assigned this Mar 17, 2022
@pull-request-size pull-request-size bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Mar 17, 2022
@vercel vercel bot temporarily deployed to Preview March 17, 2022 00:39 Inactive
@caarlos0 caarlos0 requested a review from dirien March 17, 2022 00:39
@caarlos0 caarlos0 added the enhancement New feature or request label Mar 17, 2022
@caarlos0 caarlos0 marked this pull request as ready for review March 17, 2022 00:40
@codecov
Copy link

codecov bot commented Mar 17, 2022 •
edited
Loading

Codecov Report

Merging #2982 (7c09ddc) into main (31df0a0) will decrease coverage by 0.22%.
The diff coverage is 40.00%.

@@            Coverage Diff             @@
##             main    #2982      +/-   ##
==========================================
- Coverage   84.51%   84.29%   -0.23%     
==========================================
  Files         111      111              
  Lines        8997     9002       +5     
==========================================
- Hits         7604     7588      -16     
- Misses       1120     1141      +21     
  Partials      273      273
Impacted Files Coverage Δ
internal/pipe/docker/api_buildpack.go 0.00% <ø> (-85.72%) ⬇️
internal/pipe/docker/docker.go 90.00% <0.00%> (-1.53%) ⬇️
internal/deprecate/deprecate.go 94.11% <100.00%> (+0.36%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 31df0a0...7c09ddc. Read the comment docs.

@pull-request-size pull-request-size bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 17, 2022
@vercel vercel bot temporarily deployed to Preview March 17, 2022 01:20 Inactive
@vercel vercel bot temporarily deployed to Preview March 17, 2022 01:21 Inactive
@caarlos0
Merge remote-tracking branch 'origin/main' into deprecate-buildpacks
39619b1 
Signed-off-by: Carlos A Becker <caarlos0@gmail.com>
@vercel vercel bot temporarily deployed to Preview March 17, 2022 01:59 Inactive
@caarlos0
Merge remote-tracking branch 'origin/main' into deprecate-buildpacks
7c09ddc 
Signed-off-by: Carlos A Becker <caarlos0@gmail.com>
@vercel vercel bot temporarily deployed to Preview March 17, 2022 02:41 Inactive
dirien
dirien approved these changes Mar 17, 2022
View reviewed changes
Copy link
Contributor

@dirien dirien left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

There is one linting issue!

developer-guy
developer-guy approved these changes Mar 17, 2022
View reviewed changes
Copy link
Member

@developer-guy developer-guy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@caarlos0
Copy link
Member Author

There is one linting issue!

Golangci lint is not working in go 1.18 yet 🥲

@caarlos0 caarlos0 merged commit 0a66b3d into main Mar 17, 2022
@caarlos0 caarlos0 deleted the deprecate-buildpacks branch March 17, 2022 10:55
@github-actions github-actions bot added this to the v1.7.0 milestone Mar 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@developer-guy developer-guy developer-guy approved these changes

@dirien dirien dirien approved these changes

Assignees

@caarlos0 caarlos0

Labels
enhancement New feature or request size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v1.7.0
Development

Successfully merging this pull request may close these issues.

Proposal: Removal of buildpack option
3 participants
@caarlos0 @developer-guy @dirien