feat: add ko support #3653

caarlos0 · 2022-12-21T02:33:29Z

continuing the PR by @developer-guy

should be a publisher, as it does publish the images it builds every time
Default method does not work
the fromConfig thing should probably be on the defaults, too
wire --skip-ko
documentation
more tests
use same registry as docker tests does
see if we can make the log output match goreleaser's
??

closes #2556
closes #3490

Signed-off-by: Batuhan Apaydın <batuhan.apaydin@trendyol.com>

Signed-off-by: Carlos A Becker <caarlos0@users.noreply.github.com>

codecov · 2022-12-21T02:46:28Z

Codecov Report

Merging #3653 (2d2649d) into main (48f77f9) will increase coverage by 0.09%.
The diff coverage is 87.64%.

@@            Coverage Diff             @@
##             main    #3653      +/-   ##
==========================================
+ Coverage   83.60%   83.70%   +0.09%     
==========================================
  Files         118      119       +1     
  Lines        9963    10214     +251     
==========================================
+ Hits         8330     8550     +220     
- Misses       1316     1338      +22     
- Partials      317      326       +9

Impacted Files	Coverage Δ
internal/pipe/publish/publish.go	`78.57% <ø> (ø)`
pkg/config/config.go	`95.21% <ø> (ø)`
pkg/context/context.go	`100.00% <ø> (ø)`
internal/pipe/ko/ko.go	`86.46% <86.46%> (ø)`
cmd/release.go	`100.00% <100.00%> (ø)`
internal/testlib/docker.go	`72.97% <100.00%> (+31.79%)`	⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Signed-off-by: Carlos A Becker <caarlos0@users.noreply.github.com>

vercel · 2022-12-21T03:42:34Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated
goreleaser	🔄 Building (Inspect)		Dec 21, 2022 at 3:42AM (UTC)

Signed-off-by: Carlos A Becker <caarlos0@users.noreply.github.com>

cloudflare-workers-and-pages · 2022-12-29T16:20:56Z

Deploying with Cloudflare Pages

Latest commit:	`2d2649d`
Status:	✅ Deploy successful!
Preview URL:	https://996396f5.goreleaser.pages.dev
Branch Preview URL:	https://feature-2556.goreleaser.pages.dev

View logs

caarlos0 · 2022-12-29T17:05:25Z

hey @developer-guy, can you take a look? especially the docs (https://feature-2556.goreleaser.pages.dev/customization/ko/)

imjasonh

This looks great! Thanks for keeping this moving. Just a few smallish comments.

imjasonh · 2023-01-10T17:52:56Z

www/docs/customization/ko.md

+
+```yaml
+# .goreleaser.yaml
+kos:


Can this be ko: instead?

it's pluralized because it can be multiple KO configurations... is the pluralization a problem? If it is, I can change...

We could build an OCI image with ko for different binaries built from the same repository, which is why I designed it that way.

www/docs/customization/ko.md

imjasonh · 2023-01-10T17:54:56Z

pkg/config/config.go

@@ -916,6 +935,7 @@ type Project struct {
 	Brews           []Homebrew       `yaml:"brews,omitempty" json:"brews,omitempty"`
 	AURs            []AUR            `yaml:"aurs,omitempty" json:"aurs,omitempty"`
 	Krews           []Krew           `yaml:"krews,omitempty" json:"krews,omitempty"`
+	Kos             []Ko             `yaml:"kos,omitempty" json:"kos,omitempty"`


Suggested change

Kos []Ko `yaml:"kos,omitempty" json:"kos,omitempty"`

Ko []Ko `yaml:"ko,omitempty" json:"ko,omitempty"`

imjasonh · 2023-01-10T17:57:19Z

internal/pipe/ko/ko.go

+		}
+
+		if ko.BaseImage == "" {
+			ko.BaseImage = chainguardStatic


We should try to reuse whatever const ko defines upstream, in case we ever change the default base image in a future ko release.

Luckily @developer-guy has already started toward that in ko-build/ko#904, which we can reuse here when ko.BaseImage is not defined by the user.

yep, totally agree

not merged/released yet, right? we can change this in the future then

yep, it is not released yet, it is waiting for merge right now

imjasonh · 2023-01-10T17:58:31Z

internal/pipe/ko/ko.go

+		if len(ko.Platforms) == 0 {
+			ko.Platforms = []string{"linux/amd64"}
+		}
+
+		if len(ko.Tags) == 0 {
+			ko.Tags = []string{"latest"}
+		}
+
+		if ko.SBOM == "" {
+			ko.SBOM = "spdx"
+		}


I think these should also be defaults that ko maintains upstream. If we ever change them in the future we don't want to have to go hunting for other places these have been set downstream.

cool, I can PR those there too

Co-authored-by: Jason Hall <jason@chainguard.dev>

Signed-off-by: Carlos A Becker <caarlos0@users.noreply.github.com>

caarlos0 · 2023-01-16T03:53:36Z

TestPublishPipeError/publish_fail started failing and I have no idea why... @imjasonh @developer-guy any guesses? It should fail to publish to a fake registry, but always succeeds, you can even see the log from KO:

I don't understand why it could succeed...

Signed-off-by: Batuhan Apaydın <batuhan.apaydin@trendyol.com>

developer-guy · 2023-01-16T11:39:37Z

TestPublishPipeError/publish_fail started failing and I have no idea why... @imjasonh @developer-guy any guesses? It should fail to publish to a fake registry, but always succeeds, you can even see the log from KO:

I don't understand why it could succeed...

I found the problem and fixed it with cd78015.

PTAL @caarlos0

caarlos0 · 2023-01-16T14:27:40Z

ahh good catch @developer-guy , I knew it must be something "easy" that I was missing

Signed-off-by: Carlos A Becker <caarlos0@users.noreply.github.com>

developer-guy · 2023-01-16T14:45:33Z

I've open a PR to fix this problem in ko project side: ko-build/ko#932

caarlos0 · 2023-01-16T15:00:39Z

I did a few changes in your commit too, let me know what you think @developer-guy

Signed-off-by: Carlos A Becker <caarlos0@users.noreply.github.com>

caarlos0 · 2023-01-16T19:32:38Z

update docs, fixed the main (was being ignored :kek:), I think we are good to merge now!

Signed-off-by: Carlos A Becker <caarlos0@users.noreply.github.com>

actions-user and others added 3 commits December 19, 2022 10:28

chore: docs auto-update

b3a8f68

Signed-off-by: Batuhan Apaydın <batuhan.apaydin@trendyol.com>

Merge remote-tracking branch 'origin/main' into feature/2556

7be6d7b

Signed-off-by: Carlos A Becker <caarlos0@users.noreply.github.com>

refactor: many improvements

2aabbbb

Signed-off-by: Carlos A Becker <caarlos0@users.noreply.github.com>

pull-request-size bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Dec 21, 2022

vercel bot temporarily deployed to Preview December 21, 2022 02:33 Inactive

chore: go mod tidy

4a27f64

Signed-off-by: Carlos A Becker <caarlos0@users.noreply.github.com>

vercel bot temporarily deployed to Preview December 21, 2022 02:35 Inactive

refactor: rename

8924dc0

Signed-off-by: Carlos A Becker <caarlos0@users.noreply.github.com>

test: more tests

45c43c1

Signed-off-by: Carlos A Becker <caarlos0@users.noreply.github.com>

vercel bot temporarily deployed to Preview December 21, 2022 02:48 Inactive

fix: wire --skip-ko

1d08120

Signed-off-by: Carlos A Becker <caarlos0@users.noreply.github.com>

vercel bot temporarily deployed to Preview December 21, 2022 02:50 Inactive

caarlos0 added the enhancement New feature or request label Dec 21, 2022

caarlos0 added this to the v1.14.0 milestone Dec 21, 2022

caarlos0 added 2 commits December 21, 2022 00:17

feat: update deps

371c574

Signed-off-by: Carlos A Becker <caarlos0@users.noreply.github.com>

test: more platforms

d847fc7

Signed-off-by: Carlos A Becker <caarlos0@users.noreply.github.com>

vercel bot temporarily deployed to Preview December 21, 2022 03:18 Inactive

caarlos0 added 3 commits December 21, 2022 00:20

test: improve coverage

cc3c32a

test: added tests and improve error handling

dc7d272

test: more tests

4054a05

Signed-off-by: Carlos A Becker <caarlos0@users.noreply.github.com>

vercel bot temporarily deployed to Preview December 21, 2022 03:41 Inactive

test: more tests

d9ddfa8

Signed-off-by: Carlos A Becker <caarlos0@users.noreply.github.com>

vercel bot temporarily deployed to Preview December 21, 2022 03:43 Inactive

caarlos0 requested a review from developer-guy December 21, 2022 04:04

Merge remote-tracking branch 'origin/main' into feature/2556

fbc3b0e

vercel bot temporarily deployed to Preview December 21, 2022 04:08 Inactive

caarlos0 mentioned this pull request Dec 21, 2022

fix: possible race condition when applying templates to flags/ldflags ko-build/ko#913

Merged

fix: race

69d11bd

Signed-off-by: Carlos A Becker <caarlos0@users.noreply.github.com>

Merge remote-tracking branch 'origin/main' into feature/2556

42988d7

vercel bot temporarily deployed to Preview December 29, 2022 02:43 Inactive

Merge branch 'main' into feature/2556

bebab48

vercel bot temporarily deployed to Preview December 29, 2022 16:21 Inactive

imjasonh reviewed Jan 10, 2023

View reviewed changes

caarlos0 and others added 5 commits January 11, 2023 09:42

Update www/docs/customization/ko.md

239520b

Co-authored-by: Jason Hall <jason@chainguard.dev>

Merge remote-tracking branch 'origin/main' into feature/2556

9624aff

Signed-off-by: Carlos A Becker <caarlos0@users.noreply.github.com>

docs: update

f760923

Signed-off-by: Carlos A Becker <caarlos0@users.noreply.github.com>

Merge branch 'main' into feature/2556

d7198d6

test: fix

ff5f8a3

Signed-off-by: Carlos A Becker <caarlos0@users.noreply.github.com>

fix tags and dockerrepo/imagerepo

cd78015

Signed-off-by: Batuhan Apaydın <batuhan.apaydin@trendyol.com>

developer-guy mentioned this pull request Jan 16, 2023

fix the message in defalt publisher to avoid having misunderstanding ko-build/ko#931

Closed

fix: improve validation et al

6153914

Signed-off-by: Carlos A Becker <caarlos0@users.noreply.github.com>

caarlos0 added 3 commits January 16, 2023 12:09

chore: buidl

0014180

Signed-off-by: Carlos A Becker <caarlos0@users.noreply.github.com>

fix: tags, main

30c81b2

Signed-off-by: Carlos A Becker <caarlos0@users.noreply.github.com>

docs: update

32def9c

Signed-off-by: Carlos A Becker <caarlos0@users.noreply.github.com>

caarlos0 added 4 commits January 16, 2023 21:45

test: fixes

c052437

Signed-off-by: Carlos A Becker <caarlos0@users.noreply.github.com>

docs: fix link

9f594fe

docs: improvements

0a939fa

Merge remote-tracking branch 'origin/main' into feature/2556

2d2649d

caarlos0 merged commit 2450746 into main Jan 17, 2023

caarlos0 deleted the feature/2556 branch January 17, 2023 01:34

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: add ko support #3653

feat: add ko support #3653

caarlos0 commented Dec 21, 2022 •

edited

Loading

codecov bot commented Dec 21, 2022 •

edited

Loading

vercel bot commented Dec 21, 2022

cloudflare-workers-and-pages bot commented Dec 29, 2022 •

edited

Loading

caarlos0 commented Dec 29, 2022

imjasonh left a comment

imjasonh Jan 10, 2023

caarlos0 Jan 11, 2023

developer-guy Jan 11, 2023

imjasonh Jan 10, 2023

imjasonh Jan 10, 2023

developer-guy Jan 11, 2023

caarlos0 Jan 11, 2023

developer-guy Jan 16, 2023

imjasonh Jan 10, 2023

caarlos0 Jan 11, 2023

caarlos0 commented Jan 16, 2023

developer-guy commented Jan 16, 2023 •

edited

Loading

caarlos0 commented Jan 16, 2023

developer-guy commented Jan 16, 2023

caarlos0 commented Jan 16, 2023

caarlos0 commented Jan 16, 2023

	Kos []Ko `yaml:"kos,omitempty" json:"kos,omitempty"`
	Ko []Ko `yaml:"ko,omitempty" json:"ko,omitempty"`

feat: add ko support #3653

feat: add ko support #3653

Conversation

caarlos0 commented Dec 21, 2022 • edited Loading

codecov bot commented Dec 21, 2022 • edited Loading

Codecov Report

vercel bot commented Dec 21, 2022

cloudflare-workers-and-pages bot commented Dec 29, 2022 • edited Loading

Deploying with Cloudflare Pages

caarlos0 commented Dec 29, 2022

imjasonh left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

caarlos0 commented Jan 16, 2023

developer-guy commented Jan 16, 2023 • edited Loading

caarlos0 commented Jan 16, 2023

developer-guy commented Jan 16, 2023

caarlos0 commented Jan 16, 2023

caarlos0 commented Jan 16, 2023

caarlos0 commented Dec 21, 2022 •

edited

Loading

codecov bot commented Dec 21, 2022 •

edited

Loading

cloudflare-workers-and-pages bot commented Dec 29, 2022 •

edited

Loading

developer-guy commented Jan 16, 2023 •

edited

Loading