-
-
Notifications
You must be signed in to change notification settings - Fork 928
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add url_template in brew section #735
feat: add url_template in brew section #735
Conversation
Codecov Report
@@ Coverage Diff @@
## master #735 +/- ##
==========================================
- Coverage 88.95% 88.17% -0.79%
==========================================
Files 45 45
Lines 2082 2105 +23
==========================================
+ Hits 1852 1856 +4
- Misses 188 205 +17
- Partials 42 44 +2
Continue to review full report at Codecov.
|
Maybe it would be better to add a Then, it would work for other things as well (e.g.: http upload pipe). What do you think? |
@caarlos0 I agree with you. |
@caarlos0 I've done. Please, review. |
Hi, sorry for the delay... I don't think we need to add those fields into the tmpl package, the user could just write the url template, eg. tmpl is supposed to be generic for a lot of places... |
@caarlos0 Done. |
Just a small comment, and then we're good. The build failure you can fix by adding a version to the context being used on the test failing - or you can leave it for me and I fix it later :) Thanks for the PR 🚀 |
@caarlos0 Done. Ready for review. |
Thanks @mgrachev ! |
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Hi there!
goreleaser
can publish archives to s3, but can't use s3-links inbrew
formulas. This solution fixes that.