fix: Avoid panic if target is blank/dir and no packager is specified. #179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pull-request-size
bot
added
the
size/M
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/goreleaser/nfpm/kkwz8jz5n |
pull-request-size
bot
added
size/S
|
I fixed the messy error definition and rebased. |
erikgeiser
force-pushed
the
fix/cmd-error-handling
branch
from
ed29e6f
to
3d72a94
Compare
|
thanks! |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #157 I accidentally introduced a bug that results in a panic if
--targetis a directory or blank. This pull request fixes this by printing a useful error message instead.A minor issue: The
doPackage()line limit enforced bygolangci-lint:funlenis exceeded by 4 lines which in my opinion is acceptable, so i added// nolint:funlen.