Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add the PAXHeaders for file checksum required by alpine 3.13+ #291

Merged
merged 1 commit into from
Feb 3, 2021

Conversation

djgilcrease
Copy link
Contributor

@djgilcrease djgilcrease commented Feb 2, 2021

closes #288

@vercel
Copy link

vercel bot commented Feb 2, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/goreleaser/nfpm/5envinvcg
✅ Preview: https://nfpm-git-get-checksums-added-to-apk.goreleaser.vercel.app

@pull-request-size pull-request-size bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Feb 2, 2021
@vercel vercel bot temporarily deployed to Preview February 2, 2021 21:56 Inactive
@vercel vercel bot temporarily deployed to Preview February 2, 2021 22:01 Inactive
@pull-request-size pull-request-size bot removed the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Feb 3, 2021
@vercel vercel bot temporarily deployed to Preview February 3, 2021 00:32 Inactive
@pull-request-size pull-request-size bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Feb 3, 2021
@pull-request-size pull-request-size bot removed the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Feb 3, 2021
@vercel vercel bot temporarily deployed to Preview February 3, 2021 00:39 Inactive
@pull-request-size pull-request-size bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Feb 3, 2021
@djgilcrease djgilcrease changed the title WIP: fix: add the PAXHeaders for file checksum required by alpine 3.13+ fix: add the PAXHeaders for file checksum required by alpine 3.13+ Feb 3, 2021
@pull-request-size pull-request-size bot removed the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Feb 3, 2021
@vercel vercel bot temporarily deployed to Preview February 3, 2021 01:01 Inactive
@pull-request-size pull-request-size bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Feb 3, 2021
@codecov
Copy link

codecov bot commented Feb 3, 2021

Codecov Report

Merging #291 (463b039) into master (de0df62) will decrease coverage by 0.06%.
The diff coverage is 73.68%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #291      +/-   ##
==========================================
- Coverage   70.17%   70.10%   -0.07%     
==========================================
  Files           9        9              
  Lines        1103     1104       +1     
==========================================
  Hits          774      774              
  Misses        204      204              
- Partials      125      126       +1     
Impacted Files Coverage Δ
apk/apk.go 70.33% <73.68%> (-0.30%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update de0df62...463b039. Read the comment docs.

@pull-request-size pull-request-size bot removed the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Feb 3, 2021
@vercel vercel bot temporarily deployed to Preview February 3, 2021 01:17 Inactive
@pull-request-size pull-request-size bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Feb 3, 2021
@vercel vercel bot temporarily deployed to Preview February 3, 2021 02:29 Inactive
Copy link
Member

@caarlos0 caarlos0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing work @djgilcrease!

LGTM

@djgilcrease djgilcrease merged commit 3b7e015 into master Feb 3, 2021
@djgilcrease djgilcrease deleted the get-checksums-added-to-apk branch February 3, 2021 04:37
@nxadm
Copy link

nxadm commented Feb 5, 2021

Sorry, this PR needs some work and should best be reverted:
From: 3b7e015#commitcomment-46779187
@djgilcrease, this fix does not work as intended. Yes, the packages are installed, but in my case it blows the size of the package from 15MB ot 81MB compressed:

With nfpm before PR:

-rw-r--r--    1 root     root       14.9M Feb  5 08:12 rakudo-pkg-Alpine3.11_2020.12-01_x86_64.apk
-rw-r--r--    1 root     root         101 Feb  5 08:12 rakudo-pkg-Alpine3.11_2020.12-01_x86_64.apk.sh
-rw-r--r--    1 root     root         174 Feb  5 08:12 rakudo-pkg-Alpine3.11_2020.12-01_x86_64.apk.sha512

With a build from this PR:

total 81M    
-rw-r--r--    1 root     root       81.3M Feb  5 07:06 rakudo-pkg-Alpine3.11_2020.12-01_x86_64.apk
-rw-r--r--    1 root     root         101 Feb  5 07:06 rakudo-pkg-Alpine3.11_2020.12-01_x86_64.apk.sh
-rw-r--r--    1 root     root         174 Feb  5 07:06 rakudo-pkg-Alpine3.11_2020.12-01_x86_64.apk.sha512

@caarlos0 caarlos0 mentioned this pull request Feb 10, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Mar 7, 2021

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 7, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Alpine 3.13 requires file checksums embedded in the apk
3 participants