Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix apk versioning #514

Merged
merged 2 commits into from
May 30, 2022
Merged

Fix apk versioning #514

merged 2 commits into from
May 30, 2022

Conversation

kpenfound
Copy link
Contributor

Fixes #474

Following examples from https://wiki.gentoo.org/wiki/Version_specifier as well as https://wiki.alpinelinux.org/wiki/APKBUILD_Reference#pkgver

I used Info.Prerelease as the pkgver.suf as described above, since that maps most similarly to the semver prerelease field. It potentially has some overlap with Info.VersionMetadata though. For parity with these fields for other package types in nfpm, it would maybe make sense to append both Prerelease and VersionMetadata to the version, however we would have to ensure that only one of the two fields is used.

Maybe it's better to expect the user to put {letter} and {suf{#}} in Info.Version instead.

@pull-request-size pull-request-size bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label May 26, 2022
@codecov
Copy link

codecov bot commented May 26, 2022

Codecov Report

Merging #514 (7ac92ae) into main (1e26cfc) will decrease coverage by 0.03%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #514      +/-   ##
==========================================
- Coverage   66.12%   66.09%   -0.04%     
==========================================
  Files          16       16              
  Lines        1916     1914       -2     
==========================================
- Hits         1267     1265       -2     
  Misses        510      510              
  Partials      139      139              
Impacted Files Coverage Δ
apk/apk.go 71.91% <100.00%> (-0.16%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1e26cfc...7ac92ae. Read the comment docs.

@caarlos0 caarlos0 merged commit eb26ce3 into goreleaser:main May 30, 2022
@caarlos0
Copy link
Member

LGTM, thanks!

@github-actions github-actions bot added this to the 2.15.0 milestone May 30, 2022
@caarlos0 caarlos0 modified the milestones: 2.15.0, v2.16.0 Jun 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

apk version strings are incorrect
2 participants