Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: windows #690

Merged
merged 1 commit into from
Jul 13, 2023
Merged

fix: windows #690

merged 1 commit into from
Jul 13, 2023

Conversation

caarlos0
Copy link
Member

@caarlos0 caarlos0 commented Jul 10, 2023 •
edited
Loading

fixed all backslash issues that I/the CI found

refs goreleaser/goreleaser#4174

@caarlos0 caarlos0 requested a review from erikgeiser July 10, 2023 12:52
@pull-request-size pull-request-size bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jul 10, 2023
@cloudflare-pages
Copy link

cloudflare-pages bot commented Jul 10, 2023 •
edited
Loading

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: b193007
Status: ✅  Deploy successful!
Preview URL: https://82638576.nfpm.pages.dev
Branch Preview URL: https://windows.nfpm.pages.dev

View logs

@caarlos0 caarlos0 mentioned this pull request Jul 10, 2023
Merged
djgilcrease
djgilcrease approved these changes Jul 10, 2023
View reviewed changes
Copy link
Contributor

@djgilcrease djgilcrease left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pull-request-size pull-request-size bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 11, 2023
@codecov
Copy link

codecov bot commented Jul 11, 2023 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (main@d710da8). Click here to learn what that means.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #690   +/-   ##
=======================================
  Coverage        ?   74.79%           
=======================================
  Files           ?       10           
  Lines           ?     2384           
  Branches        ?        0           
=======================================
  Hits            ?     1783           
  Misses          ?      425           
  Partials        ?      176
Impacted Files Coverage Δ
apk/apk.go 73.23% <100.00%> (ø)
arch/arch.go 78.57% <100.00%> (ø)
deb/deb.go 71.80% <100.00%> (ø)
files/files.go 76.64% <100.00%> (ø)
internal/glob/glob.go 85.07% <100.00%> (ø)
rpm/rpm.go 70.50% <100.00%> (ø)

@pull-request-size pull-request-size bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 11, 2023
@caarlos0

This comment was marked as outdated.

Sign in to view
@caarlos0 caarlos0 added bug Something isn't working enhancement New feature or request labels Jul 12, 2023
@caarlos0 caarlos0 changed the title fix: clean windows slashes fix: windows Jul 12, 2023
@pull-request-size pull-request-size bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jul 12, 2023
@caarlos0
fix: windows issues
b193007 
Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com>
djgilcrease
djgilcrease approved these changes Jul 13, 2023
View reviewed changes
Copy link
Contributor

@djgilcrease djgilcrease left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@caarlos0 caarlos0 merged commit d309eb6 into main Jul 13, 2023
42 checks passed
@caarlos0 caarlos0 deleted the windows branch July 13, 2023 01:09
@github-actions github-actions bot added this to the v2.27.0 milestone Jul 13, 2023
caarlos0 added a commit to goreleaser/goreleaser that referenced this pull request Jul 14, 2023
@caarlos0
fix(nfpm): lintian unix path (#4175)
52792f4 
closes #4174
needs goreleaser/nfpm#690

---------

Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com>
@caarlos0 caarlos0 modified the milestones: v2.27.0, 2.32.0 Sep 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djgilcrease djgilcrease djgilcrease approved these changes

@erikgeiser erikgeiser Awaiting requested review from erikgeiser

Assignees
No one assigned
Labels
bug Something isn't working enhancement New feature or request size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v2.32.0
Development

Successfully merging this pull request may close these issues.
2 participants
@caarlos0 @djgilcrease