Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(rpm): support relocatable packages #691

Merged
merged 1 commit into from
Jul 11, 2023
Merged

feat(rpm): support relocatable packages #691

merged 1 commit into from
Jul 11, 2023

Conversation

caarlos0
Copy link
Member

closes #640

@pull-request-size pull-request-size bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jul 11, 2023
@caarlos0 caarlos0 self-assigned this Jul 11, 2023
@caarlos0 caarlos0 added enhancement New feature or request and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jul 11, 2023
@cloudflare-pages
Copy link

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 2bd8ea4
Status: ✅  Deploy successful!
Preview URL: https://e8466803.nfpm.pages.dev
Branch Preview URL: https://relocatable-rpm.nfpm.pages.dev

View logs

@codecov
Copy link

codecov bot commented Jul 11, 2023

Codecov Report

Merging #691 (2bd8ea4) into main (c87f56f) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #691      +/-   ##
==========================================
+ Coverage   74.85%   74.86%   +0.01%     
==========================================
  Files          10       10              
  Lines        2390     2391       +1     
==========================================
+ Hits         1789     1790       +1     
  Misses        425      425              
  Partials      176      176              
Impacted Files Coverage Δ
nfpm.go 84.93% <ø> (ø)
rpm/rpm.go 70.50% <100.00%> (+0.10%) ⬆️

Copy link
Contributor

@djgilcrease djgilcrease left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@caarlos0 caarlos0 merged commit 741acf8 into main Jul 11, 2023
40 checks passed
@caarlos0 caarlos0 deleted the relocatable-rpm branch July 11, 2023 04:39
@github-actions github-actions bot added this to the v2.27.0 milestone Jul 11, 2023
@caarlos0 caarlos0 modified the milestones: v2.27.0, 2.32.0 Sep 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for creating relocatable RPM packages using nfpm
2 participants