Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade assume-no-moving-gc to the latest version. #128

Open
wipsel opened this issue Jun 27, 2022 · 4 comments
Open

Upgrade assume-no-moving-gc to the latest version. #128

wipsel opened this issue Jun 27, 2022 · 4 comments

Comments

@wipsel
Copy link

wipsel commented Jun 27, 2022

Hi

We have been using this package in some of our projects. It has been working great so far. Since go 1.18 we have a panic caused by assume-no-moving-gc. This can be fixed by setting the env var : ASSUME_NO_MOVING_GC_UNSAFE_RISK_IT_WITH=go1.18

I updated the version in go.mod and it looks like everything is working. I don't know if this has any other implications. But Would be nice to get rid of the panic and update the package to go 1.18?

I'll try to create a pull request with the changes.

@wipsel
Copy link
Author

wipsel commented May 17, 2023

Hi again

Since the last version 3 new go versions have been released. I was wondering why go4.org/unsafe/assume-no-moving-gc is imported and if we could get rid of it in the future so that we won't need update it every time the go runtime is updated.

@chewxy
Copy link
Member

chewxy commented May 17, 2023

Arghhhhh! I thought I updated this. I even tweeted about updating this!! I need to go find the machine where I made the change, as I suspect I didn't make a push.

@pdevine
Copy link

pdevine commented Jan 30, 2024

I just ran into this problem. Any chance for a fix?

@pdevine
Copy link

pdevine commented Mar 15, 2024

I ended up just forking the repo into pdevine/tensor and patching that to not through the error. I'll kill that fork if this ever gets updated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants