optimization for the array structure #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the test will not fail in case of a change of the formatting directive
The value is populated on a call to Data()
1 similar comment
|
For info, there is a bench done in onnx-go |
|
Gentleman and scholar |
chewxy
requested changes
May 30, 2019
|
|
||
| // Pointer returns the pointer of the first value of the slab, as an unsafe.Pointer | ||
| func (t *array) Pointer() unsafe.Pointer { return t.Ptr } | ||
| func (a *array) Pointer() unsafe.Pointer { return a.Ptr } |
There was a problem hiding this comment.
These should be left as t otherwise govet shouts at you
There was a problem hiding this comment.
Strange, I changed it on purpose because go vet was shouting at me, telling me that the name of the receiver was not consistent with the other methods.
I will change it back.
There was a problem hiding this comment.
nah I may have an older version of govet. Keep it
|
|
||
| // Data returns the representation of a slice. | ||
| func (a array) Data() interface{} { return a.v } | ||
| func (a array) Data() interface{} { |
| @@ -360,8 +365,11 @@ func copyDenseIter(dst, src DenseTensor, diter, siter Iterator) (int, error) { | |||
| return copyDense(dst, src), nil | |||
| } | |||
|
|
|||
| if !dst.IsNativelyAccessible() || !src.IsNativelyAccessible() { | |||
| return 0, errors.Errorf(inaccessibleData, "copy") | |||
| if !dst.IsNativelyAccessible() { | |||
| @@ -45,10 +46,12 @@ func TestSaveLoadNumpy(t *testing.T) { | |||
| t.Error(err) | |||
| } | |||
|
|
|||
| expected := "[[ 1. 5.]\n [ 10. -1.]]\n" | |||
| expected := `\[\[\s*1\.\s*5\.\]\n \[\s*10\.\s*-1\.\]\]\n` | |||
|
Ok to merge? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The value field is not initialized when the structure is created.
The population of the value is made when on call to
Data()if the value isnil