You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Since the loop in L10 ranges over a, there is no need to reslice a in L8 to force a bound check on a. Although no instruction is generated for L8 (at least not in optimized mode, where I have checked), perhaps it may be a good idea to not have this and similar lines lingering in the source? If so, you may also want to update README.md to say it is b = b[:len(a)] that is critical.
(Just to be clear, yes, the reslice of b in L9 is indeed critical for BCE. I am only talking about L8 here.)
The text was updated successfully, but these errors were encountered:
vecf64/arith.go
Lines 8 to 10 in 6314d1b
Since the loop in L10 ranges over
a
, there is no need to reslicea
in L8 to force a bound check ona
. Although no instruction is generated for L8 (at least not in optimized mode, where I have checked), perhaps it may be a good idea to not have this and similar lines lingering in the source? If so, you may also want to updateREADME.md
to say it isb = b[:len(a)]
that is critical.(Just to be clear, yes, the reslice of
b
in L9 is indeed critical for BCE. I am only talking about L8 here.)The text was updated successfully, but these errors were encountered: