fix bad regex: all URLs were seen as needing punycoding

gorhill · Sep 13, 2017 · 04a41d8 · 04a41d8
1 parent 5626b50
commit 04a41d8
Showing 1 changed file with 2 additions and 5 deletions.
diff --git a/platform/webext/vapi-webrequest.js b/platform/webext/vapi-webrequest.js
@@ -93,16 +93,13 @@ vAPI.net.registerListeners = function() {
     };
 
     var punycode = self.punycode;
-    var reMustNormalizeHostname  = /[^0-9a-z._-]/;
+    var reAsciiHostname  = /^https?:\/\/[0-9a-z_.:@-]+[/?#]/;
     var parsedURL = new URL('about:blank');
 
     var normalizeRequestDetails = function(details) {
         details.tabId = details.tabId.toString();
 
-        if (
-            mustPunycode === true &&
-            reMustNormalizeHostname.test(details.url) === true
-        ) {
+        if ( mustPunycode && !reAsciiHostname.test(details.url) ) {
             parsedURL.href = details.url;
             details.url = details.url.replace(
                 parsedURL.hostname,