Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blocking MindGeek (PornHub Network (PHN)/Spankwire Sites (SS)) for good #1357

Closed
flyingzebras opened this issue Feb 9, 2016 · 14 comments
Closed

Comments

@flyingzebras
Copy link

flyingzebras commented Feb 9, 2016

Rewritten and moved to uBlockOrigin/uAssets#151

@Betsy25
Copy link

Betsy25 commented Feb 9, 2016

Find a girlfriend & dump porn. 😚

@ghost
Copy link

ghost commented Feb 9, 2016

You are aware that such filters wouldn't block the popunders? Furthermore EasyList already has issues with unblocking stuff on PHub and other sites due to their broad blocking filters (see for example https://forums.lanik.us/viewtopic.php?f=64&t=22376 or https://forums.lanik.us/viewtopic.php?f=64&t=28168).

@Betsy25 Get out. :>

@gorhill
Copy link
Owner

gorhill commented Feb 9, 2016

Closing and marking as invalid, as per CONTRIBUTING.

@ghost
Copy link

ghost commented Feb 9, 2016

It's not possible to include a filter like that. See #1322.

By whitelisting phncdn.com you're also working against EasyList filters which AFAIK is not something @gorhill wants to do.

@gorhill
Copy link
Owner

gorhill commented Feb 9, 2016

*,~phncdn.com$third-party,important,domain=pornhub.com is not a valid filter. Read carefully about ABP filter syntax.

@flyingzebras flyingzebras changed the title Blocking PornHub Network and Spankwire Sites for good Blocking the PornHub Network (PHN)/Spankwire Sites (SS) for good Feb 16, 2016
@flyingzebras flyingzebras changed the title Blocking the PornHub Network (PHN)/Spankwire Sites (SS) for good Blocking MindGeek (PornHub Network (PHN)/Spankwire Sites (SS)) for good Feb 16, 2016
@flyingzebras
Copy link
Author

@gorhill In assets/ublock/filters.txt, can you please expand ||traffichunt.com^$document,popunder,popup to:

||traffichunt.com^$document,popunder,popup
||trhnt.com^$document,popunder,popup
||trhunt.com^$document,popunder,popup

These domains have randomly been used on all Spankwire Sites (SS) for a long time now.

gorhill added a commit that referenced this issue Mar 1, 2016
@gorhill
Copy link
Owner

gorhill commented Mar 1, 2016

I did not use the popunder option, uBO 1.6.4 should be able to foil popunders as well with ||trhnt.com^$document,popup etc., if you can confirm please.

@flyingzebras
Copy link
Author

@gorhill Thanks, but why do you use popunder for traffichunt then?

@gorhill
Copy link
Owner

gorhill commented Mar 1, 2016

Because this one was added before 1.6.4. I will remove the popunder where unneeded after 1.6.4 is out.

@flyingzebras
Copy link
Author

flyingzebras commented Mar 1, 2016

@gorhill What about #1389?

@gorhill
Copy link
Owner

gorhill commented Mar 1, 2016

What about #1389?

#1389 is one out of currently 100 open issues.

@flyingzebras
Copy link
Author

flyingzebras commented Mar 1, 2016

@gorhill Sorry, I didn't mean to push you. I just wonder when I should re-evaluate this issue.

@gorhill
Copy link
Owner

gorhill commented Mar 1, 2016

You don't need to ask me ever again, when the issue is fixed it will be closed and GitHub will notify you.

gorhill added a commit to uBlockOrigin/uAssets that referenced this issue Apr 1, 2016
@flyingzebras
Copy link
Author

uBlockOrigin/uAssets#82

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants