Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Popup user interface refreshed while on same page #1389

Closed
flyingzebras opened this issue Feb 16, 2016 · 39 comments
Closed

Popup user interface refreshed while on same page #1389

flyingzebras opened this issue Feb 16, 2016 · 39 comments
Labels

Comments

@flyingzebras
Copy link

I noticed that these filters are incompatible, they hide flugubluc.com in uBO's own popup window:

filmvf.net,filmstreaming-hd.com,gaara-fr.com,gaytube.com,gum-gum-streaming.com,hentaifr.net,hentaihaven.org,tuxboard.com,xstory-fr.com##script:inject(phenv-defuser.js)
||flugubluc.com^$third-party,domain=gaytube.com

The prior filter is found in uBlock filters and have a tendency to make the latter filter useless.

Why do they interfere?

@gorhill
Copy link
Owner

gorhill commented Feb 16, 2016

make the latter filter useless

What does "useless" mean exactly here? Please describe the specific behavior, "useless" is vague.

@flyingzebras
Copy link
Author

@gorhill filmvf.net,filmstreaming-hd.com,gaara-fr.com,gaytube.com,gum-gum-streaming.com,hentaifr.net,hentaihaven.org,tuxboard.com,xstory-fr.com##script:inject(phenv-defuser.js) white list flugubluc.com so ||flugubluc.com^$third-party,domain=gaytube.com won't be used.

@gorhill
Copy link
Owner

gorhill commented Feb 16, 2016

This makes no sense, phenv-defuser.js can't cause uBO to whitelist anything. Provide repro steps please.

@gorhill
Copy link
Owner

gorhill commented Feb 16, 2016

The filter ||flugubluc.com^$third-party,domain=gaytube.com does not make sense. Try ||flugubluc.com^$third-party instead.

@flyingzebras
Copy link
Author

@gorhill If I only want to block flugubluc.com on gaytube.com then (as part of this test suite)?

@gorhill
Copy link
Owner

gorhill commented Feb 16, 2016

||flugubluc.com^$domain=gaytube.com.

Now, you will have to substantiate your claim that the filter is rendered useless by some injected script -- this makes no sense. I won't try to pull information from you anymore, it's time-consuming. Be proactive: investigate and provide evidence for your claim. I will re-open if you do so.

@gorhill gorhill closed this as completed Feb 16, 2016
@flyingzebras
Copy link
Author

@gorhill

*$third-party,domain=extremetube.com|gaytube.com|keezmovies.com|mofosex.com|peeperz.com|pornhub.com|porniq.com|pornmd.com|redtube.com|redtube.com.br|spankwire.com|thumbzilla.com|tube8.com|tube8.es|tube8.fr|xtube.com|youporn.com|youporngay.comwill block selipuquoe.com but not flugubluc.com, on say http://www.gaytube.com/information. This happens only when 3rd-party filters -> uBlock filters are active and it boils down to this rule: filmvf.net,filmstreaming-hd.com,gaara-fr.com,gaytube.com,gum-gum-streaming.com,hentaifr.net,hentaihaven.org,tuxboard.com,xstory-fr.com##script:inject(phenv-defuser.js). Can you please explain why?

Both selipuquoe.com and flugubluc.com are third-party domains.

@lewisje
Copy link

lewisje commented Feb 16, 2016

Look in the logger to see which whitelist rules are actually applied: I can tell that the filter you just posted is not a whitelist rule, and neither is the filter you first posted, although that one didn't explicitly block those domains either.

@ghost
Copy link

ghost commented Feb 16, 2016

Use the logger.

@flyingzebras
Copy link
Author

@lewisje @IDKwhattoputhere Can you reproduce this #1389 (comment) ?

@flyingzebras
Copy link
Author

@IDKwhattoputhere Why would EasyList white list flugubluc.com only when filmvf.net,filmstreaming-hd.com,gaara-fr.com,gaytube.com,gum-gum-streaming.com,hentaifr.net,hentaihaven.org,tuxboard.com,xstory-fr.com##script:inject(phenv-defuser.js) is in use, but not otherwise?

@ghost
Copy link

ghost commented Feb 16, 2016

I don't understand what you mean.

@flyingzebras
Copy link
Author

@IDKwhattoputhere Turn off uBlock filters: 377 benutzt aus 347 Leere den Cache and reload gaytube.com in the logger. Now you will notice that flugubluc.com is not loaded.

@ghost
Copy link

ghost commented Feb 16, 2016

Look at the second screenshot.

@flyingzebras
Copy link
Author

@IDKwhattoputhere I just noticed. We get different results.

@ghost
Copy link

ghost commented Feb 16, 2016

Post a screenshot like mine.

@flyingzebras
Copy link
Author

script-inject

@gorhill @IDKwhattoputhere As you can see flugubluc.com shows in uBOs popup windows with default settings but not when I disable 3rd-party filters -> uBlock filters which in addition will show http://www.gaytube.com/?gtdoi in the logger. The differences are marked red. This example was used on the main page of gaytube.com.

Contents from `http://www.gaytube.com/?gtdoi` in the logger
16:34:39                font    http://static.images-gaytube.com/fonts/opensans/v10/cJZKeOuBrn4kERxqtaUH3T8E0i7KZn-EPnyo3HZu7kw.woff
16:34:38                script  http://ss.phncdn.com/networkbar-3.2.2.js
16:34:38                script  http://static.images-gaytube.com/js/categories.js?v=v20
16:34:38                script  http://static.images-gaytube.com/js/dist/main.min.js?v=v20
16:34:38                css http://static.images-gaytube.com/css/dist/main.min.css?v=v20
16:34:38                inline-script   http://www.gaytube.com/
16:34:36                doc http://www.gaytube.com/

@lewisje
Copy link

lewisje commented Feb 16, 2016

In the uBlock Origin popup menu, click the icon just to the right of the eyedropper; that's the logger. Then take a screenshot of the logger just like @IDKwhattoputhere did.

@ghost
Copy link

ghost commented Feb 16, 2016

The script is loaded both times. Isn't that the opposite of what you said?

@flyingzebras
Copy link
Author

@IDKwhattoputhere Yes, I assumed that the popup window shold work as expected but it didn't. @lewisje @gorhill notice the red mark in the popup window on the screenshot.

@lewisje
Copy link

lewisje commented Feb 16, 2016

What we want to see is what precisely is whitelisting the domain.

@ghost
Copy link

ghost commented Feb 16, 2016

It's EasyList. The actual problem here is that the popup user interface isn't displaying the domain. @gorhill will have to evaluate if this needs to be fixed or not.

@flyingzebras
Copy link
Author

@IDKwhattoputhere Yes, and it all boils down to 3rd-party filters -> uBlock filters that uses the filter filmvf.net,filmstreaming-hd.com,gaara-fr.com,gaytube.com,gum-gum-streaming.com,hentaifr.net,hentaihaven.org,tuxboard.com,xstory-fr.com##script:inject(phenv-defuser.js)

So that filter interfere with uBO's own popup window.

@flyingzebras flyingzebras changed the title script:inject incompatible with block filter phenv-defuser.js interfere with uBO's own popup window Feb 16, 2016
@ghost
Copy link

ghost commented Feb 16, 2016

I think this is causing the issue, not the filter:
How would phenv-defuser.js interfere when "uBlock filters" is disabled?

@flyingzebras
Copy link
Author

@IDKwhattoputhere

Are you sure? Please read the first description in this post

If not, should document be added somewhere?

@ghost
Copy link

ghost commented Feb 16, 2016

A filter won't help. Since the document is loaded it causes the popup user interace to refresh. I don't know if this is a bug of the popup user interace or somewhere else in uBO or just a quirk of that website.

@ghost
Copy link

ghost commented Feb 16, 2016

Your filter ||flugubluc.com^$third-party,domain=gaytube.com is useless no matter what since EasyList is whitelisting the script. Use ABP and you will encounter the same problem.

@flyingzebras
Copy link
Author

@IDKwhattoputhere Yeah, but this issue can help fixing a bug as you said. Then I get less confused when I evaluate my filters.

@ghost
Copy link

ghost commented Feb 16, 2016

Yes, but phenv-defuser.js interfere with uBO's own popup window is wrong. And if you really want to block flugubluc.com you can try to use the important filter option.

@flyingzebras
Copy link
Author

@IDKwhattoputhere Please give me a suitable title and I will change it.

@ghost
Copy link

ghost commented Feb 16, 2016

Maybe Popup user interface refreshed while on same page.

@flyingzebras flyingzebras changed the title phenv-defuser.js interfere with uBO's own popup window Popup user interface refreshed while on same page Feb 16, 2016
@gorhill
Copy link
Owner

gorhill commented Feb 16, 2016

Since the document is loaded it causes the popup user interace to refresh.

Was the URL of the tab changed to http://www.gaytube.com/?gtdoi? If so, everything works just as expected.

In my fiddling with the phenv defuser, I noticed that the neutered script often prevent such redirects.

@flyingzebras
Copy link
Author

@gorhill

Was the URL of the tab changed to http://www.gaytube.com/?gtdoi?

No.

Also, did you read #1389 (comment) ?

@gorhill gorhill reopened this Feb 16, 2016
@gorhill
Copy link
Owner

gorhill commented Feb 16, 2016

There is a quirk specific to Firefox here. Unclear whether this is fixable.

So far my understanding is that uBO receives a "Location Change" event after it has started to process the document. A "Location Change" event will cause all the data collated from the page to be reset (as occur when a page is force-reloaded), and so the record that there was a network request to flugubluc.com is lost.

"Location Change" events are always received before the network request to fetch the document is processed. For some reasons it does not seem to happen here. Using synchronous messaging from in LocationChangeListener.prototype.onLocationChange does not help -- as if the issue is within Firefox itself.

@flyingzebras
Copy link
Author

@gorhill

There is a quirk specific to Firefox here. Unclear whether this is fixable.

I think it is best to ask Firefox developers:

Also, EasyList have been requested to block flugubluc.com. If you do not know how to reproduce this issue then please make use of it before gaytube might stop using flugubluc.com.

@smed79
Copy link

smed79 commented Feb 19, 2016

@flyingzebras why you want to block flugubluc.com & selipuquoe.com ?

@flyingzebras
Copy link
Author

@smed79 Both of them are ad domains.

@smed79
Copy link

smed79 commented Feb 19, 2016

@flyingzebras No ads from these domains ! selipuquoe.com is added in an iframe created for example on http://jeu.info/ by this script http://dtf.goyavelab.com/dtct.js the trick is used exactly to avoid using an exception filter and eventually using a super-general exception filter which can enable ads on other sites. This main selipuquoe.com is used to detect if you block ads on your browser... (load only an pixel image 1x1).

all domains http://pastebin.com/raw/sJ9aaCX9

Try these filters on http://jeu.info/uphill-rush-6.html

@@||dtf.goyavelab.com/dtct.js$script
@@||selipuquoe.com^$image,~third-party
@@||infojeu.com/*.js?$script,third-party
@@||adnxs.com^$domain=jeu.info
@@||pagead2.googlesyndication.com/pagead/js/adsbygoogle.js$script,domain=jeu.info

@flyingzebras
Copy link
Author

@smed79 The main focus here is to fix the bug that is triggered by flugubluc.com. Thank you for letting me know that selipuquoe.com is used for ad blocking detection though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants