Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switching configuration tabs stops list updates #2394

Closed
neroux opened this issue Feb 19, 2017 · 4 comments
Closed

Switching configuration tabs stops list updates #2394

neroux opened this issue Feb 19, 2017 · 4 comments

Comments

@neroux
Copy link

neroux commented Feb 19, 2017

Clicking "Update now" under "3rd-party filters" and then immediately switching to another tab in the configuration appears to abort the update.

Tested with uBlock 1.11 on Firefox 54 and Chrome 58.

@gorhill
Copy link
Owner

gorhill commented Feb 20, 2017

It does not stop it, it's just that the visuals are reset when you reload the tab.

@gorhill gorhill closed this as completed Feb 20, 2017
@neroux
Copy link
Author

neroux commented Feb 20, 2017

Have you tried it?

Here, it does stop it. The lists do not get updated when one clicks to another configuration tab during the update. If one re-opens the configuration and that tab afterwards the lists in questions are still out-of-date and the update button is active.


On an unrelated issue, it is a bit disappointing that you shut #2391, without even reacting to my question (#2391 (comment)) as this does not leave the chance to a civilised discussions as to the pros and cons of that feature and the whys why some people ask for it and why you seem to be so utterly opposed to the idea.

@gorhill
Copy link
Owner

gorhill commented Feb 20, 2017

Have you tried it?

Yes, all the filter lists are updated when I come back after a minute.

@neroux
Copy link
Author

neroux commented Feb 20, 2017

Yes, all the filter lists are updated when I come back after a minute.

Thanks, I tried just that right now and yes, it did work.

My apologies, my bad, I apparently did not wait long enough.

May I still suggest to re-apply the visual settings when the tab is opened and an update is in progress? Could be low priority but it could prevent any such confusion. Still, my apologies for premature assumptions :)

@gorhill gorhill reopened this Feb 20, 2017
gorhill added a commit that referenced this issue May 19, 2019
Related issue:
- #2394

Additionally, I added a new advanced setting to control
how long after launch an auto-update session should be
started -- value is in seconds:

    autoUpdateDelayAfterLaunch 180
@gorhill gorhill closed this as completed May 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants