-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
uBlock Origin 1.13.0 is disabled by Chrome #2720
Comments
Same here on Chrome 60.0.3112.32 (Official Build) beta (64-bit) on Windows 10 64-bit. Repair didn't solve the problem. Neither did removing and reinstalling. |
It seems to happen on current Release and Beta channels, but not on Canary (61.0.3136.0). |
Same issue, running Kubuntu with Chrome 59.0.3071.104, 64-bit |
The same problem on Chrome 59.0.3071.109 Windows 10 64-bit. |
Same issue on Version 59.0.3071.109 macOS 10.12.6 Beta 64-bit |
Describe the issueUpdated to latest version of google chrome caused the extension to be "This extension may have been corrupted." Screenshot in which the issue can be seenSteps for anyone to reproduce the issue
Your settings[If you fail to provide this info, I will mark the issue as invalid. Lists all settings which differs from default settings]
Your filter lists |
It's working in Vivaldi Snapshot 1.11.880.3, which is based on Chromium 59.0.3071.104. So there seems to be a Chrome specific change involved. |
this might be relevant:
(from https://bugs.chromium.org/p/chromium/issues/detail?id=729978#c8) edit: probably not, attaching log in separate comment |
|
@michaelhood Good guess, but I'm afraid it's something different.
However, it does provide a link to another Chrome extension to replicate that issue on. Would anyone like to try? |
That may have been fixed on June 7, but that doesn't mean it's landed in a shipped Chrome milestone. And js/tab.js, in 1.13.0, is 36864 bytes.. which is 4096*9. And:
|
@michaelhood You are right. Also, that would explain why @Lurtzae's Canary build does not have this problem. Then a temporary fix would be to add a byte or a few to every problematic file? |
Can't reproduce it in Canary build of v61, so apparently only stable and beta builds are affected. |
I just download uBlock Origin 1.12.4 's source code , load extension from my disk, then it work well! |
I can confirm that downloading the release seperately (I used 1.13.0) and dropping the folder into chrome works. To reproduce, just download one of the releases, unpack the zip, open the extensions tab and drop the folder into the window. |
I can not reproduce on windows 10 x64 v1703 with chrome v59.0.3071.109 (64-bit official build). I used the Update extension now button to update uBO v1.13. |
same here :// |
Having the same issue after the extension auto updated :( |
Any way to work around this yet? I tried the download then dropping that onto Chrome, which works, but all my settings have gone. I even tried copying the code to the same folder as the broken one but Chrome continues to report it as corrupted. |
same here |
After 1.13 installation, it was still corrupted. |
@lgenier doesn't seem to work for me :-( |
Microsoft Windows [Version 10.0.14393] Google Chrome 59.0.3071.109 (正式版本) (64 位) uBlock Origin 1.13.0 Same issue. |
Google Chrome: 59.0.3071.109 (64 bits) |
I've installed it by dropping the downloaded folder into the extension page and removed the corrupted webstore extension. It says on the extension page that the extension is loaded from the downloaded folder. |
@lgenier yes but that also loses your settings, as I stated earlier |
On my windows 10 system it is broken but on my arch linux install it isn't.. hm |
No worries @gorhill , Manual installation of plugin resolves the issue. |
Clicking "update extensions now" a few times has pulled the updated extension down for me. |
Ok, I see 1.13.2 is now marked as published in my Chrome store dashboard (possibly the publication of the fix was fast-tracked by the Chrome store people.) |
It's appeared for me too, and isn't disabled anymore. Thank-you. |
I was getting this corrupt problem as well and now once it updated to 1.13.2 all my filters/settings are gone :/ |
You can try recovering the rules by using file undelete applications (R-Studio Undelete is my favourite) or by using any hex editor (there are plenty free/open source ones) on your partition and finding any rule that you remember you had. I'm going to do both. I have a backup but it's quite old unfortunately. |
My understanding is that Chrome did not uninstall the extension despite the (false positive) corruption detection. If the extension is not uninstalled, I am pretty sure all your settings should be preserved. Did you uninstalled uBO? If so, the settings are gone, Chrome will completely remove an extension-specific storage when it's uninstalled. Only recourse is that you backed up your settings and can restore. |
Where are the settings stored because I have backups and have tried restoring the v1.2 extension folder, starting Chrome, but it then says it's corrupted again and a repair simply deletes the folder with a new version and no settings. |
I also have a backup but not with the most recent changes. Do you know which file(s) should we looking for with R-Studio in order to have access to the rules?
I didn't uninstalled it. uBlock Origin 1.13 installed on my browser, said it was corrupted. Then i came here and saw you released a fix. I went to the extensions page and hit update. It updated successfully but now all my settings are gone. |
It seems like the "restore" button resets everything related to a particular add-on, including its entire storage/settings/configuration. |
I don't think this is properly fixed - I revert back to v1.12, start Chrome, it then updates to v1.13.2 and still says "corrrupt". I don't think it likes being installed to a working copy, as the repair as mentioned above seems to clear it all so the "bug" gets deleted along with our settings. |
I can only speculate, extensions can't see the file system, they just save/load through the chrome.storage.local API. Looking at the file hierarchy on my side (Linux), it looks like the chrome.storage.local API may be saving stuff in For Windows or MacOS, that would be a similar directory path I suppose. But as said, it's only speculation, Google Chrome people are better placed to answer this. |
Create a new rule and then open ublock's dashboard ( chrome-extension://cjpalhdlnbpafiamejdnhcphjbkeiagm/dashboard.html#1p-filters.html ) - you'll see how rules look like. You might want to look for "! " (without quotes) in text files. |
I did not click the Uninstall button, I just clicked the repair button. But all the settings are gone, including cloud storage. uBlock Origin version is 1.13.2 |
As per Google Chrome documentation, it does look like the Repair button is equivalent of uninstalling then reinstalling the extension. |
Recovering custom made filters is nigh impossible unless you have a backup because they are stored in a binary (!) database here:
Good luck extracting them from this file. I hate Google Chrome. |
Yea, i clicked that, sorry, i should've said. I managed to recover the 1.12.4 folder but when i replace it in the extensions directory it says it's corrupted. Well, GG chrome. Guess there's nothing we can do now. |
@Taomyn Something worth to try: Maybe try to backup the content of the |
Can confirm restoring a backup of the Local Extension Settings folder brings back custom filters OK. |
since cloud storage got wiped out for some reason it's clear the cloud sync is far from bulletproof enough, may I recommend that every time you click "export to cloud storage" it also triggers a "back up to file" action |
@dobata Could you open a separate issue for this? I have been trying to see what could be done in order to backup data in some automatic way, but I couldn't find a satisfactory solution -- for example automatically backing up on a regular basis (say once a week) could easily end up bloating the Downloads directory. I find your idea is interesting. |
That the cloud storage was wiped must be a Google Chrome issue (or by design, when an extension is uninstalled), since uBO will never write to the cloud storage without the user explicitly pressing the button to do so. |
@gorhill thanks, in the end I restored the entire Chrome folder in my profile and then when I started Chrome it was able to upgrade successfully and nothing was lost except for the cloud settings. |
Thanks for fixing! |
@gorhill As a (really late) follow up to this disastrous browser bug (that lead to few hundred thousand users uninstalling uBO), I would like to make a simple (not time-consuming) proposal: |
I know this is a bit late and random, but I was just hit by the same problem, and I'm coding a CI script to automatically pad files. This issue affects Chrome 60 as well.
If you publish the update from command line, the review takes like 3 seconds. |
Just noticed that uBlock Origin got disabled for me following update from Chrome 59 to 60 today. It didn't say "extension is corrupted" but it was just disabled. Don't know, might still be an active issue or not. |
Chrome hints uBlock Origin 1.13.0 may has been corrupted. I delete the extension and reinstall from Chrome Web Store, but still displaying extension may has been corrupted.
Chrome Version: 59.0.3071.109
OS: macOS Sierra 10.12.5
uBlock Origin Version: 1.13.0
The text was updated successfully, but these errors were encountered: