Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

uBlock Origin 1.13.0 is disabled by Chrome #2720

Closed
AndreaVEH opened this issue Jun 21, 2017 · 71 comments
Closed

uBlock Origin 1.13.0 is disabled by Chrome #2720

AndreaVEH opened this issue Jun 21, 2017 · 71 comments

Comments

@AndreaVEH
Copy link

image

Chrome hints uBlock Origin 1.13.0 may has been corrupted. I delete the extension and reinstall from Chrome Web Store, but still displaying extension may has been corrupted.

Chrome Version: 59.0.3071.109
OS: macOS Sierra 10.12.5
uBlock Origin Version: 1.13.0

@Compgeke
Copy link

Same problem happening for me as well, also Chrome 59.0.3071.109 and ublock 1.13.0. Only difference is I'm on Windows 7 64-bit rather than Mac OS.

ublock_corrupted

@thusgaard
Copy link

thusgaard commented Jun 21, 2017

Same here on Chrome 60.0.3112.32 (Official Build) beta (64-bit) on Windows 10 64-bit.

Repair didn't solve the problem. Neither did removing and reinstalling.

@Lurtzae
Copy link

Lurtzae commented Jun 21, 2017

It seems to happen on current Release and Beta channels, but not on Canary (61.0.3136.0).

@DrColossos
Copy link

Same issue, running Kubuntu with Chrome 59.0.3071.104, 64-bit

@mozkan007
Copy link

The same problem on Chrome 59.0.3071.109 Windows 10 64-bit.

@ergenekonyigit
Copy link

Same issue on Version 59.0.3071.109 macOS 10.12.6 Beta 64-bit

@3k2
Copy link

3k2 commented Jun 21, 2017

Describe the issue

Updated to latest version of google chrome caused the extension to be "This extension may have been corrupted."

Screenshot in which the issue can be seen

screenshot of version

Steps for anyone to reproduce the issue

  1. Be as detailed as possible: Update google chrome and go to extension tab you'll notice the extension is broken. If you try to repair it will install it again but issue remains.

Your settings

[If you fail to provide this info, I will mark the issue as invalid. Lists all settings which differs from default settings]

SETTINGS

  • OS/version: Windows 10
  • Browser/version: Chrome Latest stable
  • uBlock Origin version: Latest stable
Your filter lists

FILTERS
FILTERS2

@Lurtzae
Copy link

Lurtzae commented Jun 21, 2017

It's working in Vivaldi Snapshot 1.11.880.3, which is based on Chromium 59.0.3071.104. So there seems to be a Chrome specific change involved.

@michaelhood
Copy link

michaelhood commented Jun 21, 2017

this might be relevant:

Summary: files that are of size equals multiple of content hash's block_size (4096 bytes) always fail content verification due to bug. The file in question: hide_default.PNG is 8192 (2 * 4096), bug 720597 is due to a file "Ancient Assyria.cwz" which is of size 16384 bytes (4 * 4096).

(from https://bugs.chromium.org/p/chromium/issues/detail?id=729978#c8)

edit: probably not, attaching log in separate comment

@michaelhood
Copy link

[3137:37379:0621/003705.949798:VERBOSE1:content_verify_job.cc(225)] job failed for cjpalhdlnbpafiamejdnhcphjbkeiagm js/vapi-client.js reason:1
[3137:37379:0621/003705.950634:VERBOSE1:content_verify_job.cc(225)] job failed for cjpalhdlnbpafiamejdnhcphjbkeiagm js/contentscript.js reason:1
[3137:37379:0621/003705.950826:VERBOSE1:content_verify_job.cc(225)] job failed for cjpalhdlnbpafiamejdnhcphjbkeiagm js/scriptlets/subscriber.js reason:1
[3137:37379:0621/003705.955597:VERBOSE1:content_verify_job.cc(225)] job failed for cjpalhdlnbpafiamejdnhcphjbkeiagm background.html reason:1

relevant logs (--enable-logging=stderr --v=1)

@bershan2
Copy link
Contributor

@michaelhood Good guess, but I'm afraid it's something different.
That issue is a duplicate and was merged with issue 720597, which is marked as Fixed on Jun 7. Also, the errors look different for that one (VerifyFailed, not job failed):

[661:1295:0509/184448.588807:VERBOSE1:content_verifier.cc(143)] VerifyFailed ifajfiofeifbbhbionejdliodenmecna reason:1

However, it does provide a link to another Chrome extension to replicate that issue on. Would anyone like to try?

@michaelhood
Copy link

That may have been fixed on June 7, but that doesn't mean it's landed in a shipped Chrome milestone.

And js/tab.js, in 1.13.0, is 36864 bytes.. which is 4096*9. And:

[3137:37379:0621/003706.170410:VERBOSE1:content_verify_job.cc(225)] job failed for cjpalhdlnbpafiamejdnhcphjbkeiagm js/tab.js reason:3

@bershan2
Copy link
Contributor

bershan2 commented Jun 21, 2017

@michaelhood You are right. Also, that would explain why @Lurtzae's Canary build does not have this problem.

Then a temporary fix would be to add a byte or a few to every problematic file?

@uBlock-user
Copy link
Contributor

uBlock-user commented Jun 21, 2017

Can't reproduce it in Canary build of v61, so apparently only stable and beta builds are affected.

@0x7E
Copy link

0x7E commented Jun 21, 2017

I just download uBlock Origin 1.12.4 's source code , load extension from my disk, then it work well!

@eerive
Copy link

eerive commented Jun 21, 2017

I can confirm that downloading the release seperately (I used 1.13.0) and dropping the folder into chrome works. To reproduce, just download one of the releases, unpack the zip, open the extensions tab and drop the folder into the window.

@michaelhood
Copy link

@bershan2 yeah, that's the workaround.. adding padding bytes to make sure you don't land on a 4k boundary.

I wrote a quick script to see which assets were afoul of this, it's indeed just js/tab.js.

@bhtbht
Copy link

bhtbht commented Jun 21, 2017

I can not reproduce on windows 10 x64 v1703 with chrome v59.0.3071.109 (64-bit official build). I used the Update extension now button to update uBO v1.13.

@toth-Daniel
Copy link

same here ://

@unyk
Copy link

unyk commented Jun 21, 2017

Having the same issue after the extension auto updated :(

@Taomyn
Copy link

Taomyn commented Jun 21, 2017

Any way to work around this yet? I tried the download then dropping that onto Chrome, which works, but all my settings have gone. I even tried copying the code to the same folder as the broken one but Chrome continues to report it as corrupted.

@artkol
Copy link

artkol commented Jun 21, 2017

same here

@lgenier
Copy link

lgenier commented Jun 21, 2017

After 1.13 installation, it was still corrupted.
Changing the chrome://flags/#extension-content-verification flag to bootstrap, and restarting browser fixed the issue.
It still works after setting the flag back to default.

@Taomyn
Copy link

Taomyn commented Jun 21, 2017

@lgenier doesn't seem to work for me :-(

@XhstormR
Copy link

Microsoft Windows [Version 10.0.14393]

Google Chrome 59.0.3071.109 (正式版本) (64 位)

uBlock Origin 1.13.0

Same issue.

@KooPad
Copy link

KooPad commented Jun 21, 2017

Google Chrome: 59.0.3071.109 (64 bits)
Same issue. With the manual installation works well.

@lgenier
Copy link

lgenier commented Jun 21, 2017

I've installed it by dropping the downloaded folder into the extension page and removed the corrupted webstore extension. It says on the extension page that the extension is loaded from the downloaded folder.
Hope this helps.

@Taomyn
Copy link

Taomyn commented Jun 21, 2017

@lgenier yes but that also loses your settings, as I stated earlier

@3k2
Copy link

3k2 commented Jun 21, 2017

On my windows 10 system it is broken but on my arch linux install it isn't.. hm

@piyush-ramavat
Copy link

piyush-ramavat commented Jun 21, 2017

No worries @gorhill , Manual installation of plugin resolves the issue.
So all good.
Thanks for quick turn around.
Cheers.

@hawky525
Copy link

Clicking "update extensions now" a few times has pulled the updated extension down for me.
All working now.

@gorhill
Copy link
Owner

gorhill commented Jun 21, 2017

Ok, I see 1.13.2 is now marked as published in my Chrome store dashboard (possibly the publication of the fix was fast-tracked by the Chrome store people.)

@Taomyn
Copy link

Taomyn commented Jun 21, 2017

It's appeared for me too, and isn't disabled anymore. Thank-you.

@verlain3
Copy link

I was getting this corrupt problem as well and now once it updated to 1.13.2 all my filters/settings are gone :/
Any way to recover them? Guess not

@birdie-github
Copy link

You can try recovering the rules by using file undelete applications (R-Studio Undelete is my favourite) or by using any hex editor (there are plenty free/open source ones) on your partition and finding any rule that you remember you had. I'm going to do both. I have a backup but it's quite old unfortunately.

@gorhill
Copy link
Owner

gorhill commented Jun 21, 2017

I was getting this corrupt problem as well and now once it updated to 1.13.2 all my filters/settings are gone :/

My understanding is that Chrome did not uninstall the extension despite the (false positive) corruption detection. If the extension is not uninstalled, I am pretty sure all your settings should be preserved. Did you uninstalled uBO? If so, the settings are gone, Chrome will completely remove an extension-specific storage when it's uninstalled. Only recourse is that you backed up your settings and can restore.

@Taomyn
Copy link

Taomyn commented Jun 21, 2017

Where are the settings stored because I have backups and have tried restoring the v1.2 extension folder, starting Chrome, but it then says it's corrupted again and a repair simply deletes the folder with a new version and no settings.

@verlain3
Copy link

You can try recovering the rules by using file undelete applications (R-Studio Undelete is my favourite) or by using any hex editor (there are plenty free/open source ones) on your partition and finding any rule that you remember you had. I'm going to do both. I have a backup but it's quite old unfortunately.

I also have a backup but not with the most recent changes. Do you know which file(s) should we looking for with R-Studio in order to have access to the rules?

My understanding is that Chrome did not uninstall the extension despite the (false positive) corruption detection. If the extension is not uninstalled, I am pretty sure all your settings should be preserved. Did you uninstalled uBO? If so, the settings are gone, Chrome will completely remove an extension-specific storage when it's uninstalled. Only recourse is that you backed up your settings and can restore.

I didn't uninstalled it. uBlock Origin 1.13 installed on my browser, said it was corrupted. Then i came here and saw you released a fix. I went to the extensions page and hit update. It updated successfully but now all my settings are gone.

@birdie-github
Copy link

Did you uninstall uBO?

It seems like the "restore" button resets everything related to a particular add-on, including its entire storage/settings/configuration.

@Taomyn
Copy link

Taomyn commented Jun 21, 2017

I don't think this is properly fixed - I revert back to v1.12, start Chrome, it then updates to v1.13.2 and still says "corrrupt". I don't think it likes being installed to a working copy, as the repair as mentioned above seems to clear it all so the "bug" gets deleted along with our settings.

@gorhill
Copy link
Owner

gorhill commented Jun 21, 2017

Where are the settings stored

I can only speculate, extensions can't see the file system, they just save/load through the chrome.storage.local API.

Looking at the file hierarchy on my side (Linux), it looks like the chrome.storage.local API may be saving stuff in [Chrome config directory]/Default/Local Extension Settings/cjpalhdlnbpafiamejdnhcphjbkeiagm for uBO.

For Windows or MacOS, that would be a similar directory path I suppose.

But as said, it's only speculation, Google Chrome people are better placed to answer this.

@birdie-github
Copy link

Do you know which file(s) should we looking for with R-Studio in order to have access to the rules?

Create a new rule and then open ublock's dashboard ( chrome-extension://cjpalhdlnbpafiamejdnhcphjbkeiagm/dashboard.html#1p-filters.html ) - you'll see how rules look like. You might want to look for

"! " (without quotes) in text files.

@XhstormR
Copy link

XhstormR commented Jun 21, 2017

I did not click the Uninstall button, I just clicked the repair button. But all the settings are gone, including cloud storage. uBlock Origin version is 1.13.2

@gorhill
Copy link
Owner

gorhill commented Jun 21, 2017

I did not click the Uninstall button, I just clicked the Fix button.

As per Google Chrome documentation, it does look like the Repair button is equivalent of uninstalling then reinstalling the extension.

@birdie-github
Copy link

Recovering custom made filters is nigh impossible unless you have a backup because they are stored in a binary (!) database here:

google-chrome/Default/Local Extension Settings/cjpalhdlnbpafiamejdnhcphjbkeiagm/000007.log

Good luck extracting them from this file. I hate Google Chrome.

@verlain3
Copy link

As per Google Chrome documentation, it does look like the Repair button is equivalent of uninstalling then reinstalling the extension.

Yea, i clicked that, sorry, i should've said.

I managed to recover the 1.12.4 folder but when i replace it in the extensions directory it says it's corrupted. Well, GG chrome. Guess there's nothing we can do now.

@gorhill
Copy link
Owner

gorhill commented Jun 21, 2017

@Taomyn Something worth to try: Maybe try to backup the content of the [Chrome config directory]/Default/Local Extension Settings/cjpalhdlnbpafiamejdnhcphjbkeiagm directory, then repair, then try to restore the content of that directory -- see if this works. Important: backup/restore the content of that directory only when Chrome is not running.

@andyeff
Copy link

andyeff commented Jun 21, 2017

Can confirm restoring a backup of the Local Extension Settings folder brings back custom filters OK.

@dobata
Copy link

dobata commented Jun 21, 2017

since cloud storage got wiped out for some reason it's clear the cloud sync is far from bulletproof enough, may I recommend that every time you click "export to cloud storage" it also triggers a "back up to file" action

@gorhill
Copy link
Owner

gorhill commented Jun 21, 2017

@dobata Could you open a separate issue for this? I have been trying to see what could be done in order to backup data in some automatic way, but I couldn't find a satisfactory solution -- for example automatically backing up on a regular basis (say once a week) could easily end up bloating the Downloads directory. I find your idea is interesting.

@gorhill
Copy link
Owner

gorhill commented Jun 21, 2017

That the cloud storage was wiped must be a Google Chrome issue (or by design, when an extension is uninstalled), since uBO will never write to the cloud storage without the user explicitly pressing the button to do so.

@Taomyn
Copy link

Taomyn commented Jun 22, 2017

@gorhill thanks, in the end I restored the entire Chrome folder in my profile and then when I started Chrome it was able to upgrade successfully and nothing was lost except for the cloud settings.

@thusgaard
Copy link

Thanks for fixing!

@bershan2
Copy link
Contributor

@gorhill As a (really late) follow up to this disastrous browser bug (that lead to few hundred thousand users uninstalling uBO), I would like to make a simple (not time-consuming) proposal:
Direct people visiting uBO store page "Support" pane to the uBO Wiki.
Currently uBO Chrome web store extension page has open "Support" tab, where people write support questions expecting a reply, which they usually never get. Instead, in the Google Developer Dashboard you could forbid comments and leave a note and a link to the Wiki Home page. Furthermore, in case of similar disaster in the future, posting a "quick fix" there would reduce frustration and save many people's time.

@jspenguin2017
Copy link
Contributor

jspenguin2017 commented Aug 6, 2017

I know this is a bit late and random, but I was just hit by the same problem, and I'm coding a CI script to automatically pad files. This issue affects Chrome 60 as well.

Add to this that each time I publish, the Chrome store puts uBO in "Pending review" mode and it may take a while for the fix to actually be available.

If you publish the update from command line, the review takes like 3 seconds.

https://github.com/jspenguin2017/uBlockProtector/blob/master/Continuous%20Integration/3-build.node.js#L303-L407

@eliask
Copy link

eliask commented Aug 24, 2017

Just noticed that uBlock Origin got disabled for me following update from Chrome 59 to 60 today. It didn't say "extension is corrupted" but it was just disabled.

Don't know, might still be an active issue or not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests