Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

userResourcesLocation URL appears twice in the logger #3586

Closed
uBlock-user opened this issue Mar 9, 2018 · 5 comments
Closed

userResourcesLocation URL appears twice in the logger #3586

uBlock-user opened this issue Mar 9, 2018 · 5 comments

Comments

@uBlock-user
Copy link
Contributor

uBlock-user commented Mar 9, 2018

Describe the issue

userResourcesLocation URL appears twice in the logger when uBlock Filters is updated.

Screenshot in which the issue can be seen

Steps for anyone to reproduce the issue

  1. Open Advanced Settings page and paste https://raw.githubusercontent.com/uBlock-user/uBO-Scriptlets/master/scriptlets.txt at userResourcesLocation as the URL and save it.

  2. Open 3rd party Filters page and open the logger page for it, now click on the clock icon near uBlock Filters, followed by clicking on Update Now button.

  3. Observe the logger page and notice there's a double entry for https://raw.githubusercontent.com/uBlock-user/uBO-Scriptlets/master/scriptlets.txt

Your settings

  • OS/version: Win 10
  • Browser/version: Chromium 67
  • uBlock Origin version: 1.15.11.9
@uBlock-user
Copy link
Contributor Author

P.S - As seen from the screenshot, the network requests are shown as behind-the-scene which didn't happen before, was this an intended change ?

@gorhill
Copy link
Owner

gorhill commented Mar 9, 2018

which didn't happen before

This has always been behind the scene, these are requests made by uBO, there is no tab associated with the extension.

@uBlock-user
Copy link
Contributor Author

Really ? I remembered differently perhaps..

@uBlock-user
Copy link
Contributor Author

Can no longer reproduce this, so closing. Logger refactorisation must have taken care of this for good.

@gorhill
Copy link
Owner

gorhill commented Apr 20, 2019

I could reproduce today. There is a race condition so this may or may not be reproduced according to how fast resources are updated. If they update fast, the resource file may be pulled twice. Anyway, I will push an update where this is fixed.

gorhill added a commit that referenced this issue Apr 20, 2019
The URLs must be space-separated.

Reminders:
- The additional resources will be updated at the same time
  the built-in resource file is updated
- Purging the cache of 'uBlock filters' will also purge the
  cache of the built-in resource file -- and hence force a
  reload of the user's custom resources if any

Related issues:
- #3307
- uBlockOrigin/uAssets#5184 (comment)

Addtionally:
- Opportunitically promisified assets.fetchText()
- Fixed #3586
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants