-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Speed and Dynamic-filtering:-precedence #527
Comments
I don't understand the issue report. What do you mean by "don't disable this 3rd-party"? |
@ruy-benton In dynamic filtering, site-specific rules will take precedence over more general rules. So even if you block 3rd party scripts generally, the site-specific rule |
Edit: Understand the concept and implementation of @gorhill and the comments in the end of this thread.
@RoxKilly But ... for example http://www.ic.ac.uk I block 3rd-party frames and scripts - red in "My rules", In Logger: .... Insert: www.ic.ac.uk * * noop 10:24:31 image http://www.ic.ac.uk/NewsEvents/image/featurenews2012/28511.jpg No change ... Insert: www.ic.ac.uk * 3p-script noop 10:28:06 image http://www.ic.ac.uk/NewsEvents/image/featurenews2012/28511.jpg Static filter in action In some sites I want the local - 3p-script ... access ... I need the content of 3rd Thank you for your work and comments, |
Put in words, The
https://github.com/gorhill/uBlock/wiki/Dynamic-filtering:-precedence. The order of cells in the matrix offers a hint: the lower the cell, the higher precedence (and the more specific). |
Edit: Other users have the same comments ... Another one: @seanrand Edit: behind-the-scene * 3p noop did the trick. Might be worth adding to the wiki." |
Because there is no issue with uBlock, what you think is an issue is exactly how the precedence is documented. |
Trying to understand why I'm being quoted here, my comment was just me figuring out the precedences (which gorhill explained in this issue before closing it), sorry if that caused any confusion. |
It's very simple ... if you post or I can insert some images in WIKI. When I change "www.ic.ac.uk * 3p-script noop" ( in "3rd-party scripts" right ) -> "www.ic.ac.uk * * noop" |
@ruy-benton, I don't want to derail #528 any further, so I'm commenting here. I think I see where the confusion might stem from. Let's take this page as an example. We are using default-deny ( When you look at the matrix, you could think that A better representation of the situation would be this: Some third-party assets such as images and css are allowed (because there is no Similarly, nooping third-party scripts locally on a default-deny setup is currently represented like this in the matrix: It's not immediately obvious that some third-party requests are still being blocked (frames). This could be represented more accurately like this: @gorhill, are you following? You're already using a yellow indicator for "mixed" (some requests blocked, some allowed) in the first column of the matrix, so applying it to the second and third column would be intuitive and more accurately represent the state of dynamic filtering for a host. For completeness, another (more realistic) example: This situation is even more inconsistent, as third-party images/css are nooped and third-party scripts/frames are blocked in both cases. (I hope I'm correct - I'm not very familiar with 3p-passive yet, please correct me if I'm wrong) Both would be better represented by this: |
@seanrand translated my text -> images !!!!! Wowwwwwwwwwwwwwwwwwwww I understand @gorhill in 2 comment and write: When I change "www.ic.ac.uk * 3p-script noop" local ( in "3rd-party scripts" right ) -> "www.ic.ac.uk * * noop" and try to help you in #528 Please update WIKI with images and this will help other users. Thank you very much for your great software |
This is a quick demonstration of how inconsistencies caused by conflicting dynamic block/allow rules in the dynamic blocking matrix could be handled. A yellow-ish indicator is added to cells that are affected by more than one conflicting dynamic filtering rule. For example if 3p deny and 3p-scripts or 3p-frames allow/noop are selected, the current way of shading 3p cells red/gray does not accurately reflect the mixed state for those cells. For first-party cells, inline-script and 1p-script are affected. The display of image and all rules hasn't been changed. This is based on the idea outlined in my comment gorhill#527 (comment) refer to that for screenshots and further examples. gorhill#544
In wiki, you describe for better security - enable:
3rd-party scripts and frames, inline and 1st-party scripts.
And there is another Benefit / Advantage - IT'S SPEED.
If uBlock (Dynamic-filter) blocks all that scripts and frames ... he don't search in static filters.
I analysed https://github.com/gorhill/uBlock/wiki/Dynamic-filtering:-precedence
If I block 3rd-party frames and scripts - red in "My rules",
why the local "www.example.com * * noop" don't disable this 3rd-party?
and this disable:
"www.example.com * 3p-script noop"
"www.example.com * 3p-frame noop"
Thank you in advance for your comments
The text was updated successfully, but these errors were encountered: