New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move linting out of tools/make-nodejs.sh #3803

Merged

gorhill merged 1 commit into gorhill:master from mjethani:make-lint

Aug 4, 2021

Contributor

mjethani commented Aug 4, 2021

This patch moves the linting out of the tools/make-nodejs.sh script, as it continues to cause problems (see ghostery/adblocker#2109 (comment)).

Now the developer must run make lint explicitly.


          Move linting out of tools/make-nodejs.sh

f8f1484

Contributor Author

mjethani commented Aug 4, 2021

@gorhill in the end the way to address this will be to add a package.json file in the root and make it a development-only Node.js package.

mjethani mentioned this pull request

Integrate @adguard/tsurlfilter ghostery/adblocker#2109

Merged

gorhill merged commit 4ea0d13 into gorhill:master

mjethani deleted the make-lint branch

August 4, 2021 18:45

mjethani mentioned this pull request

Update README.md with requirements ghostery/adblocker#2110

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet