Skip to content
This repository has been archived by the owner on Jul 21, 2021. It is now read-only.

chrome crash when restoring file #40

Closed
Cilverjolt opened this issue Nov 4, 2014 · 25 comments
Closed

chrome crash when restoring file #40

Cilverjolt opened this issue Nov 4, 2014 · 25 comments

Comments

@Cilverjolt
Copy link

When I restore my settings my whole browser crashes. I'm on windows chrome dev.

@gorhill
Copy link
Owner

gorhill commented Nov 4, 2014

Crashes need to be reported to Chromium devs: javascript does not crash, the browser crashes.

Do you have an anti-virus which could interfere with the browser? If so, which one? I think I remember somebody reporting something similar, when restoring settings.

Reporting to Chromium devs is what needs to be done.

@Cilverjolt
Copy link
Author

i have panda free, voodooshield, comodofirewall. i tried disabling all my security things and it still happened. it still restores but its annoying that chrome crashes

@gorhill
Copy link
Owner

gorhill commented Nov 4, 2014

If you report to Chromium devs with detailed repro steps which causes the crash every single time, that will help them spot the problem and fix it. It's all in the repro steps.

@Cilverjolt
Copy link
Author

okay i will do that

@gorhill
Copy link
Owner

gorhill commented Nov 4, 2014

If you can reproduce at will, I would like to change something and see if I can workaround the browser bug.

@gorhill
Copy link
Owner

gorhill commented Nov 4, 2014

I tried to repro with Google Chrome 40, and it worked fine on my side. So might not be as easy to repro.

@Cilverjolt
Copy link
Author

so i reset my flags to default for chrome and it didn't crash. So sorry for bothering you it must have been a buggy chrome flag that i enabled.

@my-password-is-password
Copy link

I can confirm it was messing with the flags... again. Doesn't crash anymore since I reset to default.

@gorhill
Copy link
Owner

gorhill commented Nov 4, 2014

Would be nice to know which flag, so if ever someone else get the problem, I can ask whether the problematic flag is enabled.

@my-password-is-password
Copy link

Maybe its not the flags. I made a note of the flags I had changed before resetting,

Enable Download Resumption
Disable NTP 'Other devices' menu.
Enable SPDY/4
Enable Panels
Disable hyperlink auditing
Enable fast tab/window close
Experimental Extension APIs
Disable WebGL

I re-enabled those flags again and it doesn't crash anymore. So i'm guessing its how I just unzip a newer version of chromium on top of an old version.??? idk

@gorhill
Copy link
Owner

gorhill commented Nov 4, 2014

I re-enabled those flags again and it doesn't crash anymore

Which version of uMatrix? Note that in the latest version there is a blind attempt at workaround: 1d9a8e1. My thinking there is that maybe I should avoid restarting the extension while being called back from within a storage-related API context. The problem is defintely in the browser, however if I can find a workaround I will do it. uBlock reportedly suffers also from similar problem.

@my-password-is-password
Copy link

uMatrix.chromium-0.8.0.0-rc.1

@gorhill
Copy link
Owner

gorhill commented Nov 4, 2014

uMatrix.chromium-0.8.0.0-rc.1

You could try with 0.8.0.0-rc.0 and see if it's back crashing.

@my-password-is-password
Copy link

Ok it crashed going back to 0.8.0.0-rc.0.

umcrash

@my-password-is-password
Copy link

Let me reset the flags and try restore from a file and see if it still crashes.

Doesn't crash after resetting the flags for 0.8.0.0-rc.0. So its not a uMatrix problem.

@gorhill
Copy link
Owner

gorhill commented Nov 4, 2014

Ok it crashed going back to 0.8.0.0-rc.0

Awesome. That's the kind of narrowing the Chromium devs will find useful. So since uBlock shares the same code here, this should be reported in the uBlock issue: https://code.google.com/p/chromium/issues/detail?id=418174

@gorhill
Copy link
Owner

gorhill commented Nov 4, 2014

So its not a uMatrix problem

Crashes are never an extension problem -- it is just scripted language. But extensions can try to work around browser crashes -- until the browser is fixed.

So if I understand: some flags cause the crash, and the lottery-like workaround had nothing to do with the crash not occurring anymore?

@gorhill
Copy link
Owner

gorhill commented Nov 4, 2014

I tried to reproduce the crash on Windows 7/Google Chrome 40, and I could not, including with the flags.

I wish I could because this needs to be reported to the Chromium devs, that kind of hard crash could even be a security vulnerability. Could it please be narrowed to which flag(s) are required and report to Chromium devs?

@my-password-is-password
Copy link

Yeah just those flags listed earlier don't crash it. Let me try again because I just noticed that those flags were "enable/disable" flags. So I might have missed some flags that use a dropdown list.

@my-password-is-password
Copy link

Ok. It had nothing to do with flags. Here are the steps to crash chromium on my computer.

1.) Remove uMatrix and reset flags
2.) Close Chromium
3.) Start Chromium
4.) Install uMatrix
5.) In uMatrix try to either "Restore from file..." or "Reset to default settings"

Can reproduce every time. No other extensions running. No messing with flags.

Heres a video i made,

http://uux3.altervista.org/crash.webm

Tried with both rc.0 and rc.1. Both crashed.
Chromium Version 40.0.2210.0

@gorhill
Copy link
Owner

gorhill commented Nov 4, 2014

Can reproduce every time.

Oddly enough, I can't reproduce using these steps, neither on Chrome 40/Windows 7.

I think at this point posting your video and a crash report (this will allow the devs to know where it crashed in the source code etc.) is best move. Once you add the issue in the chromium thread a new chromium thread, I will pitch in to point out where in the extension code this occurs.

@my-password-is-password
Copy link

Is @Cilverjolt using Windows XP like me? Might be a Windows XP problem.

Ok I posted a crash report with my video on that thread.

@Cilverjolt
Copy link
Author

I'm using windows 8.1.

@my-password-is-password
Copy link

@Cilverjolt can you reproduce following the steps above?

@gorhill, heres the new thread https://code.google.com/p/chromium/issues/detail?id=430549 . Should I delete that comment in that other thread?

@Cilverjolt
Copy link
Author

I did the steps above and it worked fine. I notice it happens randomly. I tested last night activating two flags at a time to see what was crashing it and I couldn't find it. When I tried to restore from file earlier today it randomly crashed. So I'm confused as to what is causing it.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants