added enclosure and its attributes to support podcast feeds #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added test cases for enclosure for podcast usage of atom and rss feeds
|
What's the differences between this and #15 ? |
|
This pull request is my first one, adds/alters 42 lines and has rick astley in it :) |
|
I think I like this one better because it's less invasive. However, two things:
|
code now gofmt formatted
RssEnclosure.Length remains string to not break the API
|
Done as requested, unfortunately this pull request now consists of 43 (instead of 42) lines of changed code. :) |
kisielk
added a commit
that referenced
this pull request
Aug 10, 2015
added enclosure and its attributes to support podcast feeds
|
cool, thanks |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
gets used in https://github.com/PaulPetring/audiobook-feeds