Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Dialer type registered unconditionally into proxy #867

Closed
1 task done
imirkin opened this issue Nov 15, 2023 · 2 comments
Closed
1 task done

[BUG] Dialer type registered unconditionally into proxy #867

imirkin opened this issue Nov 15, 2023 · 2 comments
Labels

Comments

@imirkin
Copy link

imirkin commented Nov 15, 2023

Is there an existing issue for this?

  • I have searched the existing issues

Current Behavior

No response

Expected Behavior

No response

Steps To Reproduce

No response

Anything else?

666c197

This change seems to have switched from the private proxy copy into the project-wide golang.org/x/net/proxy. (It's vendored here, but if one vendors websocket, then it will end up using the sharedly-vendored variant.) Since the registration comes from init() there's no way to prevent it even if the client functionality in question is not needed or desired. Previously this was done into a private "copy" of the proxy logic, which was fine since it was entirely scoped to the websocket client logic. But now it's leaking out.

@imirkin imirkin added the bug label Nov 15, 2023
@ghost ghost mentioned this issue Dec 11, 2023
1 task
@ghost
Copy link

ghost commented Jul 6, 2024

Fixed by #929 (rollback coreydaley's edits) and #938 (update to use golang.org/x/net/proxy without registration).

@jaitaiwan
Copy link
Member

Closing as fixed in master. Will release soon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: ✅ Done
Development

No branches or pull requests

2 participants