-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
zxcvbn compatibility #57
Comments
Hi there @TomLottermann, that observation it wasn't an overriding goal of nbvcxz to maintain complete compatibility with zxcvbn or the other ports is entirely correct. When I started this project, there were no other Java ports and I really wanted this functionality for my company, and I wanted it in Java. By the time I was done with the initial version, zxcvbn4j was also released, and from my memory of looking over their code years ago, they did maintain closer compatibility with zxcvbn (at least at the time). Now on to ways nbvcxz can be configured to generate closer output to zxcvbn:
Hope that helps, and i'm interested in your findings if you end up testing nbvcxz and another implementation to see how similar their outputs are over a sample of passwords. |
Another difference I thought of today is the separator match type support we have. It helps with passphrases detection a lot, but since zxcvbn doesn't support it, that would be something to also disable using the ConfigurationBuilder: setPasswordMatchers(List passwordMatchers). |
@TomLottermann I am going to close this issue, hopefully my answers were helpful. If you have any more questions or need anything clarified feel free to ask. |
Sorry for the late reply. Thanks a ton for the detailed info! Might we worth documenting this in the README - maybe :) |
Good call, i'll re-open this as a reminder to add this info to the README.md under a "compatibility" section. |
@TomLottermann I updated the readme with the info from this thread, let me know if you think anything is unclear or should be reworded if you wouldn't mind. |
Thanks for the documentation update! :) |
Is there a shorthand to simply remove the |
Nope, no shorthand that I am aware of. |
We are currently building password rating into two separate clients, one Java, one C++ and would like to use native password rating libraries.
For Java we are already using nbvcxz, for C++ we want to use zxcvbn.
Ideally both clients would identify the same passwords as weak. However, reading https://github.com/GoSimpleLLC/nbvcxz#differentiating-features, I'm assuming this never was a goal of nbvcxz (which I understand).
What would it take to give nbvcxz a "compatability" mode that would make it produce the same (or at least almost the same) results as zxcvbn?
As a best-effort measure: are there some configurations that would get nbvcxz results closer aligned to the zxcvbn results?
The text was updated successfully, but these errors were encountered: