Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the ability to run dgoss when the docker daemon is not local #269

Closed
rmb938 opened this issue Jul 29, 2017 · 5 comments
Closed

Add the ability to run dgoss when the docker daemon is not local #269

rmb938 opened this issue Jul 29, 2017 · 5 comments

Comments

@rmb938
Copy link

rmb938 commented Jul 29, 2017

I have a use case where I want to run dgoss but the docker daemon is not on the local machine and the file system is not shared.

My idea would be to add a flag i.e --not-local or something and run https://goss.rocks/install inside the container to be tested then docker cp the goss yaml files.

@elliotweiser
Copy link
Contributor

👍

I was playing with a similar concept outside of dgoss, but this seems like a good/valid use-case for it.

Implementation idea: only docker cp files instead of mounting volumes during docker run. In theory this would make dgoss compatible against both local and remote docker daemons.

@aelsabbahy
Copy link
Member

Docker cp would be interesting. It would slow down dgoss a little bit and not allow testing of the log content.. but those could be disclaimers. Maybe dgoss could have a cp vs mount mode that a user can toggle though env vars.

I probably won't get around to this, but if someone submits a backwards compatible PR, I would review/merge.

@elliotweiser
Copy link
Contributor

I may have some to look into this next week

@rmb938
Copy link
Author

rmb938 commented Aug 2, 2017

Here is the script with the docker cp modifications I made. I didn't add a flag, just replaced everything with docker cp so it will need some work before it is ready for a pr https://gist.github.com/rmb938/bfc92e5cfffd69ba66aabb9bb0e656eb

Oh I also switched it to sh from bash for containers that don't have bash installed.

@aelsabbahy
Copy link
Member

aelsabbahy commented Aug 18, 2017

Closed by #271 it's on the master branch now. I usually don't cut releases for dgoss changes, so it'll be on the github "releases" tab in the next release.

See: https://github.com/aelsabbahy/goss/tree/master/extras/dgoss#goss_files_strategy

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants