Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorganize src code #60

Closed
bertt opened this issue Nov 15, 2016 · 9 comments
Closed

Reorganize src code #60

bertt opened this issue Nov 15, 2016 · 9 comments

Comments

@bertt
Copy link
Contributor

bertt commented Nov 15, 2016

Proposal:

docker-compose.yml

. gost-db 

   Dockerfile (base image mdillon/postgis)

   create_gost_db.sql

. gost-dashboard 

   Dockerfile (base image nginx)
 
   nginx.conf

   index.html

     . css

     . js

     . viewers

. gost-service 

    Dockerfile (base image golang:latest)

    main.go

    config.yaml

Ports:
. gost-dashboard: 8080
. gost-service: 8081
. gost-db: 5432

@tebben
Copy link
Contributor

tebben commented Nov 15, 2016

extra folder .gost-service means an extra addition in the go imports, making it too large for example: import (
github.com/geodan/gost/src/gost-service/sensorthings/odata
)

Other proposal, moving docker files away from the gost source code to keep it clean:

  • Move gost-dashboard to a separate repository (Tom's new Polymer dashboard?)
  • .sql creation script to folder scripts
  • Create docker folder in root or under scripts

      - machines

       - stable

         - docker-compose.yml (using gost-service and gost-db images)

         - readme.md

       - latest

         - docker-compose.yml (building from source)

         - readme.md

      - images

       - gost-service

         - Dockerfile (base image golang:latest)

         - readme.md

       - gost-db

         - Dockerfile (base image mdillon/postgis)

         - readme.md

@bertt
Copy link
Contributor Author

bertt commented Nov 15, 2016

other options:
. database code also in other repository
. remove 'src' from namespace, in my case the go code resides in D:\dev\go\src\github.com\geodan\gost\src with two times 'src' :-(

@bertt
Copy link
Contributor Author

bertt commented Dec 6, 2016

database stuff is moved to https://github.com/geodan/gost-db
dashboard stuff we'll move to https://github.com/geodan/gost-dashboard in later release

@bertt
Copy link
Contributor Author

bertt commented Apr 25, 2017

some tasks identified:

  • move html/js code to new dashboard repository
  • remove src directory from go code
  • rename this repository to gost-server

@bertt
Copy link
Contributor Author

bertt commented May 2, 2017

html/js code is copied to new repository: https://github.com/gost/dashboard
dashboard is running on nginx there

@bertt
Copy link
Contributor Author

bertt commented May 9, 2017

html/js code for dashboard is removed from this repository

@bertt
Copy link
Contributor Author

bertt commented May 15, 2017

next task: remove src directory

@bertt
Copy link
Contributor Author

bertt commented May 18, 2017

@tebben
Copy link
Contributor

tebben commented Jun 6, 2017

Removed src folder in 9a4877d

@tebben tebben closed this as completed Jun 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants