-
-
Notifications
You must be signed in to change notification settings - Fork 240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Can't edit series metadata #1491
Comments
You can enable DEBUG logs to see what's happening. Alternatively, you can check what API call the browser is sending to the backend (in the network dev tools). |
Disabling cache and restarting the page right on the series. I see the following (in order): Error on console, without doing anything yet:
While trying to add an alternative title I see the following logs, then nothing happens:
Any time that I hit "save changes" I see a PUT request with code 202. If I try to modify a series that didn't import a
And I also see a PUT (202) request followed by a PATCH (204). This is the expected behavior. Permissions are the same for both series I tried it on, only difference is that the series that was able to import the |
If you can't get SSE connectivity the webui will not get server updates, probably an incorrect reverse proxy configuration.
is the API call successful ? |
But as I stated, it works for other series. And I guess it's successful as I'm receiving the 202 status code, I don't see anything in the request itself, let me know what you're looking for here. What would be a correct proxy configuration? I'm using nginx:
Where the
|
i don't use NGinx. Please provide your DEBUG logs with successful series and unsuccessful series updates. |
I already posted the only 2 logs that show when I try to add an alternate title. Here is the full log (komga.log) since the shutdown with DEBUG enabled. 0CHJ4GYN6SHDM is the series I'm able to edit, among others. |
it seems the log file does not contain the DEBUG log statements when you edit a series metadata. You should see log statements of the form |
I'm using |
^Also not it, not sure really, there is not much in the logs |
Just tried it, Komga fails to import |
|
Yeah I know, I'm taking reference from version I'm using a tool I forked (derived from So given that Anilist returns 0 for publishing mangas, the 0 case should be handled as the |
putting 0 is wrong, you should put a number that is at least the current number of the issue |
Why would it be wrong? it's what Anilist API gives, also it is parsed as 0 in Komga, but not recognized afterwards. If I put the current number of issues, I would have to update |
it's wrong because if there's at least 1 book, then the total number of issues cannot be 0… |
It's not about having 0 books, it's about signaling that the series is ongoing publication. Else Komga would fail while parsing the 0, no? There are no checks for "current issues" > "total issues" currently |
0 means 0 books. The Mylar schema does not enforce a positive number on that. |
What does What do you mean about the "not enforcing a positive number"? |
this is not allowed by Mylar's schema.
the schema should allow
the schema should probably enforce that field to be strictly positive or null. But that's something that Mylar needs to change, they own the schema. |
Ok, sure. The schema allows 0 (and even negative numbers I guess), as you mentioned it doesn't enforce positive numbers. So why block editing other metadata when there is a 0, this is still the initial issue. This is what I'm referring to handling the 0 case, I just want to be able to leave the 0 alone and focus on adding other metadata. Either allow setting the 0 (just like when parsing) and this way other metadata can be added or show the error as soon as the edit metadata window opens (there's no validation when just opening it). |
It's 2 different things, the Mylar metadata, and the input of metadata from Komga API. |
Yes, I know. But they're not matching in allowed values right now (Mylar allows 0 while Komga doesn't). Again, it's still an issue that it is imported successfully as a 0 but Komga doesn't actually allow this value. Either fail or allow it. |
Just don't put 0 🤷🏻♂️ |
Anilist returns 0. Just don't parse the 0 from the start and provide meaningful errors. |
FWIW Anilist returns |
Your spaces were replaced by "+", but I see what you mean, you're correct. The tool is translating At this point it's not about that but to just give an error when there is a zero, either at parsing time or in the UI (because it does get parsed into zero but it's not allowed by Komga, took me a lot of time to even debug it). Also the schema supports zeros anyways, and his argument was that Komga adheres to the Again, this whole issue was because I couldn't even tell what was the error when I was trying to add other metadata, not because I WANT to use zero as the field, this was an afterthought which would help and save a lot of headaches. The zero is already being used and it behaves like |
Steps to reproduce
series.json
metadata.Expected behavior
I should be able to add or modify metadata for a series. I'm able to do this for series that are imported with incorrect
series.json
that are populated by the first book metadata.Actual behavior
Nothing happens.
Logs
I don't see any error messages, only some warnings such as:
WARN 2869 --- [o-25600-exec-26] o.s.web.servlet.PageNotFound : No mapping for GET /series/0FQEEQJRH6MEQ
Where
0FQEEQJRH6MEQ
is the id for the series I'm trying to modify.Komga version
1.11.1-master
Operating system
Arch linux 6.8.8-arch1-1
Installation method
other (please provide more details below)
Other details
I'm using the AUR package.
Acknowledgements
The text was updated successfully, but these errors were encountered: