Skip to content
This repository has been archived by the owner on Dec 10, 2019. It is now read-only.

Remove or fix Bootstrap #13

Open
pandaskii opened this issue Nov 3, 2017 · 0 comments
Open

Remove or fix Bootstrap #13

pandaskii opened this issue Nov 3, 2017 · 0 comments

Comments

@pandaskii
Copy link
Contributor

This issue is copied from https://github.com/govCMS/govCMS8-core/issues/5

Hi,
This is a bit of a convoluted one so bear with me.

  1. I added comments to a content type.
  2. When trying to delete the comment from the front end UI, it didn't work and I received what looked like an AJAX request but themed.
  3. When I went back to the node, the Comments text field was outlined in red, and the editor buttons were not appearing.
  4. When I inspected the page in Chrome, I realised there were 17 JS errors. I thought perhaps the issue was that jQuery Once was missing (as a lot of the errors were along those lines).
  5. Adding jquery.once to govcmsui.libraries.yml didn't fix anything.
  6. Drupal also started reporting this error:
    Notice: Undefined index: scope in Drupal\Core\Asset\AssetResolver->getJsAssets() (line 286 of core/lib/Drupal/Core/Asset/AssetResolver.php). Drupal\Core\Asset\AssetResolver->getJsAssets(Object, ) (Line: 145) Drupal\Core\Ajax\AjaxResponseAttachmentsProcessor->buildAttachmentsCommands(Object, Object) (Line: 113) Drupal\Core\Ajax\AjaxResponseAttachmentsProcessor->processAttachments(Object) (Line: 62) Drupal\Core\EventSubscriber\AjaxResponseSubscriber->onResponse(Object, 'kernel.response', Object) (Line: 108) Drupal\Component\EventDispatcher\ContainerAwareEventDispatcher->dispatch('kernel.response', Object) (Line: 657) Drupal\big_pipe\Render\BigPipe->filterResponse(Object, 2, Object) (Line: 635) Drupal\big_pipe\Render\BigPipe->filterEmbeddedResponse(Object, Object) (Line: 585) Drupal\big_pipe\Render\BigPipe->sendPlaceholders(Array, Array, Object) (Line: 305) Drupal\big_pipe\Render\BigPipe->sendContent(Object) (Line: 112) Drupal\big_pipe\Render\BigPipeResponse->sendContent() (Line: 425) Symfony\Component\HttpFoundation\Response->send() (Line: 20)
  7. When I fiddled around with the theme settings and turned off Bootstrap, the errors dropped from 17 to 5 (stay tuned for those last 5).

Removing Bootstrap did mess around with the layout of the site, however it isn't too bad.

Since Bootstrap is not used in UI Kit 2.0 (and Foundation was used in UI Kit 1.0), including it seems counter-intuitive. I realise that UI Kit 2.0 does not provide a particularly robust front-end structure but since the theme would only ever function as a base for a subtheme and not directly I don't think that really matters.

Thanks,
Jesse.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant