You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
If we want to nit pick on efficiency, there are also a few low-hanging network issues I think we could also leave as follow-up tasks:
Two state requests are sent on page load.
Taking a seat sends N "unsubscribe" messages, we should only need to send 1.
Two state messages are sent from the server when game state changes (I believe this is because the client subscribes to both the observer state and seat-specific state.
Oh right, the first is not resolved yet. The endpoint /games/:gameId/state/initial returns the variant and config, which are not included in endpoint /games/:gameId/state. I haven't checked this, but I believe this structure may have incidentally fixed #266 So I would like to keep it.
But maybe we can avoid that both api calls get triggered at the start.
That's a good point! And tbh two REST calls at page load is not such a big deal. Let's go ahead and close both of these, and can revisit later if API calls become an issue.
See this conversation:
The text was updated successfully, but these errors were encountered: