Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Anonymous session data not converted to user session on login: Emoji etc. #142

Open
wbt opened this issue Jul 18, 2017 · 1 comment
Open

Comments

@wbt
Copy link
Contributor

wbt commented Jul 18, 2017

If I am not logged in and click on an emoji, it indicates that I've made this selection (even on returning to the bill page later) and increments the aggregate count that everyone can see, as expected. However, if I then log in, the emoji selection data associated with the anonymous account does not get associated with my login. Viewing the bill shows me that I have selected none, and clicking again registers the response and increases the count, instead of removing the reaction and decrementing the count as a user might expect.
If I then log out, that starts another anonymous session. By logging in and out, I can increment the emoji count as high as I want on any emoji on any bill.

A possible (at least partial) fix for this would be to have the login script look for any stored data associated with an anonymous session, and convert that to the user's logged-in account.

@JoshData
Copy link
Member

Yeah. That's true. The emojis aren't important enough to warrant the extra code needed to migrate the anonymous data on login/account creation, I don't think. I doubt it occurs (for users) very often.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants