Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect scalingFactor documentation #54

Closed
jahav opened this issue Dec 5, 2021 · 2 comments
Closed

Incorrect scalingFactor documentation #54

jahav opened this issue Dec 5, 2021 · 2 comments

Comments

@jahav
Copy link

jahav commented Dec 5, 2021

Incorrect scalingFactor documentation

The documentation for PageDimensions ctor describes the scalingFactor as

Page scaling PPI factor

However, it seems to be incorrect, based on my experimentations, it is pixels per point factor, where 72 points is equal to one inch.
Example: I want 300 pixels per inch = scaling factor should be 300/72 ~ 4.1666666

Could it be changed to something like?

Page scaling factor in pixels-per-point. Convert PPI to scaling factor as PPI/72.

@Modest-as
Copy link
Member

good suggestion, updated on master

@LonelyReligion
Copy link

Weird question, but I have trouble finding project's documentation. It's trivial, but I've been searching for over an hour now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants