Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support latest 3.x #19

Open
sandergarretsen opened this issue Jan 14, 2016 · 4 comments
Open

support latest 3.x #19

sandergarretsen opened this issue Jan 14, 2016 · 4 comments

Comments

@sandergarretsen
Copy link

Trying to import the responsive-embed less styles (available since 3.1.0), I noticed it's not listed to the bootstrap-styles.loader.js.

Any chance it could be added?

@gowravshekar
Copy link
Owner

@sandergarretsen
Copy link
Author

I am using custom configuration. But the bootstrap-styles.loader.js is not importing the responsive-embed styles because it is not listed in the style array, which is filtered by the styles listed in the custom configuration?

var styles = [
...
]
source = start + styles.filter(function (style) {
  return config.styles[style];
}).map(function (style) {
  return "@import \"~bootstrap/less/" + style + ".less\";";
}).join("\n");

@ivanchoo
Copy link

ivanchoo commented Aug 6, 2016

For what it's worth, a workaround is to just add the import statement in your bootstrap.config.less

// File: bootstrap.config.less
@import "~bootstrap/less/responsive-embed.less";
.....

@ibuchan72390
Copy link

@ivanchoo , you just completely saved me, thank you so much. I had thought that the addition of 'responsive-utilities' in the bootstrap.config.js would include the responsive-embed functionality without the explicit addition to the bootstrap.config.less file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants