Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: No difference between days of the selected month vs days of the outside months. #1591

Closed
hpdganesh opened this issue Oct 28, 2022 · 0 comments · Fixed by #1592
Closed
Labels
bug Bug or Bug fixes

Comments

@hpdganesh
Copy link
Contributor

hpdganesh commented Oct 28, 2022

Bug description

When showOutsideDays is enabled, visually there is no difference between days of the selected month vs days of the outside months. Can we add styles to differentiate between actual days vs outside days

To reproduce

Fork this CodeSandbox: https://codesandbox.io/s/react-daypicker-forked-zxj1uc with the code to reproduce the issue.

Steps

1.When showOutsideDays feature is enabled, outside days of the months looks no different than the selected month. This can cause some confusion to the user
2. Render DayPicker with showOutsideDays option

Expected behavior

If we add style to differentiate the days for outside month, users can find the difference between the selected month days against the outside days

Screenshots

Current behaviour
Screen Shot 2022-10-28 at 7 10 38 AM

Expected behaviour
Screen Shot 2022-10-28 at 7 13 34 AM

Additional context

To fix this, we can add opacity as 0.5 for rdp-day_outside class

@hpdganesh hpdganesh added the bug Bug or Bug fixes label Oct 28, 2022
@hpdganesh hpdganesh changed the title Bug: Bug: No difference between days of the selected month vs days of the outside months. Oct 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Bug or Bug fixes
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant