Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update org.xhtmlrenderer dependency to flying-saucer-pdf #36

Open
timbonicus opened this issue Jul 4, 2017 · 3 comments
Open

Update org.xhtmlrenderer dependency to flying-saucer-pdf #36

timbonicus opened this issue Jul 4, 2017 · 3 comments

Comments

@timbonicus
Copy link

The rendering plugin is using org.xhtmlrenderer:core-renderer:R8, which is rather outdated. I was looking for support of the HTML TITLE tag to set the PDF title, which was added 5 years ago.

It appears the updated dependency is org.xhtmlrenderer:flying-saucer-pdf. Is it possible to get an update to this newer dependency?

@graemerocher
Copy link
Member

If I recall I believe the issue is related to licensing and itext changing from GPL to AGPL

@mctolentino
Copy link

Looks like it's safe to update to a newer dependency since flying-saucer-pdf is now using itext 2.1.7 as a dependency:
https://github.com/flyingsaucerproject/flyingsaucer/blob/master/flying-saucer-pdf/pom.xml

They've separated the itext5.5 dependent sources:
https://github.com/flyingsaucerproject/flyingsaucer/tree/master/flying-saucer-pdf-itext5

@mctolentino
Copy link

mctolentino commented Jul 31, 2017

I've created a pull request with the updated dependencies. I've encountered some issues with Travis, so I also updated some of the build configurations. Can anyone take a look at it? Thanks!

Pull Request: #38

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants