fix(nx-container): provenance 'false' ignored

gperdomor · Apr 19, 2024 · 6868733 · 6868733
1 parent 112955a
commit 6868733
Show file tree

Hide file tree

Showing 2 changed files with 20 additions and 1 deletion.
diff --git a/packages/nx-container/src/executors/build/engines/docker/docker.engine.spec.ts b/packages/nx-container/src/executors/build/engines/docker/docker.engine.spec.ts
@@ -422,6 +422,25 @@ nproc=3`],
         '--metadata-file', '/tmp/.docker-build-push-jest/metadata-file',
         'https://github.com/docker/build-push-action.git#refs/heads/test-jest:subdir'
       ]
+    ],
+    [
+      17,
+      '0.11.2',
+      new Map<string, string>([
+        ['context', '.'],
+        ['load', 'false'],
+        ['no-cache', 'false'],
+        ['push', 'false'],
+        ['pull', 'false'],
+        ['provenance', 'false'],
+      ]),
+      [
+        'build',
+        '--iidfile', '/tmp/.docker-build-push-jest/iidfile',
+        '--provenance', 'false',
+        '--metadata-file', '/tmp/.docker-build-push-jest/metadata-file',
+        '.'
+      ]
     ]
   ])(
     '[%d] given %p with %p as inputs, returns %p',

diff --git a/packages/nx-container/src/executors/build/engines/docker/docker.engine.ts b/packages/nx-container/src/executors/build/engines/docker/docker.engine.ts
@@ -161,7 +161,7 @@ export class Docker extends EngineAdapter {
     if (inputs.platforms.length > 0) {
       args.push('--platform', inputs.platforms.join(','));
     }
-    if (inputs.provenance) {
+    if (inputs.provenance || inputs.provenance === 'false') {
       args.push('--provenance', inputs.provenance);
     }
     await asyncForEach(inputs.secrets, async (secret) => {