Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

subnamespace for chrono #3

Closed
bernt-matthias opened this issue Nov 29, 2018 · 3 comments
Closed

subnamespace for chrono #3

bernt-matthias opened this issue Nov 29, 2018 · 3 comments

Comments

@bernt-matthias
Copy link

During building a new conda package for this library (bioconda/bioconda-recipes#12416) I had the problem that the compiler reported an ambiguous namespace for chrono.

Could you change this to a subnamespace as my patch here:

https://github.com/bioconda/bioconda-recipes/blob/7935ca76ad53a7263d3457afd10d6656b6eb937a/recipes/gclib/chrono.patch

or use the std::chrono and std::ratio namespaces?

@bernt-matthias
Copy link
Author

Since this part of the code seems not relevant for gffcompare I also close this issue.

Thanks for your comments and for providing the software.

@gpertea
Copy link
Owner

gpertea commented Dec 1, 2018

Agreed, though the issue is still relevant to me as there are other programs which actually use that code (fqtrim, stringtie) and I am grateful for reporting the issue and for the suggested fix (thank you!).

Could you please let me know what was the compiler & platform where the namespace conflict was encountered? I understand it's now part the recent C++ standard, just wanted to know where that was actually implemented so I can check for it (and possibly other issues) myself (I'm guessing it's the latest MacOS XCode compiler?)

@bernt-matthias
Copy link
Author

The problem occurred during building of the conda package. I'm not sure which compile is user there. But the MacOS compiler seems to be a good guess.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants