Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fastmarching_0_implementing: Error in the Eikonal update #61

Open
glennib opened this issue Jan 30, 2020 · 0 comments
Open

fastmarching_0_implementing: Error in the Eikonal update #61

glennib opened this issue Jan 30, 2020 · 0 comments

Comments

@glennib
Copy link

glennib commented Jan 30, 2020

In https://github.com/gpeyre/numerical-tours/blob/master/matlab/fastmarching_0_implementing.ipynb on In [22], the Delta is calculated as
Delta = 2*W(j) - (dx-dy)^2;
while I believe it should be
Delta = 2*W(j)^2 - (dx-dy)^2;

This doesn't matter for the example with cell sizes of 1. However, in different cell sizes, it seems to cause a numerical approximation of the L^p norm close to the goal cell, where p equals the grid size.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant