Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The documentation build is failing #1050

Closed
kristiankyvik opened this issue Mar 7, 2024 · 2 comments
Closed

The documentation build is failing #1050

kristiankyvik opened this issue Mar 7, 2024 · 2 comments
Labels
bug Something isn't working

Comments

@kristiankyvik
Copy link
Collaborator

The docs build started failing about a week ago. More concretely, it seems like they started breaking after this PR got merged.

  • I have tried to reproduce locally with no success
  • I have looked at the files changed in PR ci: added codecov.io reporting #1039 but I am struggling to understand how those changes could be connected

Once this is fixed, we will build and serve the latest changes to the docs, that have already been merged.

@kristiankyvik kristiankyvik added bug Something isn't working triage Interesting but stale issue. Will be close if inactive for 3 more days after label added. labels Mar 7, 2024
@ATheorell ATheorell removed the triage Interesting but stale issue. Will be close if inactive for 3 more days after label added. label Mar 7, 2024
@kristiankyvik
Copy link
Collaborator Author

kristiankyvik commented Mar 11, 2024

I am still struggling to reproduce this locally.

Based on build logs, I see:

  • It does seems to installs the toml package
  • But later raises the "ModuleNotFoundError: No module named 'toml'" error.

My wild guess is that this could be related to the virtual environment setup, as in the venv we use to install the packages (including toml) is not the same one where we are executing the sphinx build command.

I do not have access to the instance running the documentation build, maybe @ErikBjare you can give me hand here?

UPDATE: I think found the source of the issue, I was partially right. See this. Pushing a fix based on proposed solution.

@kristiankyvik
Copy link
Collaborator Author

This has been fixed as per PR #1059

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
Development

No branches or pull requests

2 participants