Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dEQP-VK.graphicsfuzz.mix-floor-add #211

Closed
paulthomson opened this issue Sep 13, 2019 · 7 comments
Closed

dEQP-VK.graphicsfuzz.mix-floor-add #211

paulthomson opened this issue Sep 13, 2019 · 7 comments
Assignees

Comments

@paulthomson
Copy link

This test fails. To reproduce: amdllpc -gfxip=9.0.0 -verify-ir -o temp.out *.spv

mix-floor-add.zip

@amdrexu amdrexu self-assigned this Sep 17, 2019
@amdrexu
Copy link
Contributor

amdrexu commented Sep 17, 2019

The addend is from a integer bit-cast with the value of <i32 38730, i32 63193, i32 63173>. This value is finally converted to denormals and LLVM applies constant folding for fmuladd, which causes a assert.

@MarcinKantochAMD
Copy link

I tested today and the test is passing on LLPC stack. Does it fail or throw an assert? I am testing with a release build.

@MarcinKantochAMD
Copy link

Sorry Paul. I was not aware that your issues relate to Debug build. I was testing with a Release build.

@amdrexu amdrexu removed their assignment Sep 25, 2019
@paulthomson
Copy link
Author

This still seems to fail.

@jayfoad
Copy link
Member

jayfoad commented Nov 15, 2019

This is a bug in the LLVM floating point emulation code. I've raised it upstream: https://bugs.llvm.org/show_bug.cgi?id=44010

@jayfoad
Copy link
Member

jayfoad commented Nov 19, 2019

There's a fix in upstream review: https://reviews.llvm.org/D69772
Edit: it's been committed: https://reviews.llvm.org/rGe62555c129d535d524354351791c5474c9929582

@jayfoad
Copy link
Member

jayfoad commented Dec 5, 2019

Fixed in GPUOpen-Drivers/llvm-project@e62555c.

@trenouf trenouf closed this as completed Dec 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants