New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clarify Valid Values
language in the attributes table.
#2916
Comments
That three-bullet list isn't quite right because its "or" between the first two, and "and" with the last. Before the last change I had suggested
Would that be any clearer? The 1u cannot evaluate to an i32 value because there is no feasible automatic conversion |
Even just:
the |
Works for me. |
This PR clarifies that the valid values must be either `AbstractInt` or `i32` instead of the more generate `integer literal`. Issue gpuweb#2916
This PR clarifies that the valid values must be either `AbstractInt` or `i32` instead of the more generate `integer literal`. Issue gpuweb#2916
This PR clarifies that the valid values must be either `AbstractInt` or `i32` instead of the more generate `integer literal`. Issue gpuweb#2916
* [wgsl]: Clarify attribute Valid Values. This PR clarifies that the valid values must be either `AbstractInt` or `i32` instead of the more generate `integer literal`. Issue #2916 * Review feedback
Currently says things like
It's not clear how far the "or" distributes. What would be better is to write two sentences: one about types, the other about value.
|
Split the consraint into two statements: - one is about the tyep - other is about the range of values Fixes: gpuweb#2916
Split the consraint into two statements: - one is about the tyep - other is about the range of values Fixes: gpuweb#2916
Split the consraint into two statements: - one is about the tyep - other is about the range of values Fixes: #2916
* [wgsl]: Clarify attribute Valid Values. This PR clarifies that the valid values must be either `AbstractInt` or `i32` instead of the more generate `integer literal`. Issue gpuweb#2916 * Review feedback
Split the consraint into two statements: - one is about the tyep - other is about the range of values Fixes: gpuweb#2916
Currently the
Valid Values
column says things likeinteger literal, yielding a positive i32
which I took to mean it could be1u
as an integer literal and the compiler would treat it asi32
. This seems to be incorrect and this means it can beAbstractInt
ori32
but notu32
.We should make explicit what types can be provided to the various attribute values. Even just making a list like:
Could be clearer?
The text was updated successfully, but these errors were encountered: