Remove the void type #1460
Merged
Remove the void type #1460
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dj2
reviewed
Feb 23, 2021
dj2
approved these changes
Feb 24, 2021
|
I don't think #1413 (comment) presents a strong case for keeping |
|
I think there's another option: keep the concept of the void type in the spec, but forbid authors from spelling it inside WGSL programs. We keep the philosophical type system simplicity that @dneto0 desired during today's office hours call, while removing the concept of the void type from every shader author's brain. |
|
@dneto0 this is rebased now, please have another look! |
dneto0
approved these changes
Mar 29, 2021
|
Thank you for reviewing and rebasing! |
ben-clayton
added a commit
to ben-clayton/Tint
that referenced
this pull request
Apr 13, 2021
Was removed with: gpuweb/gpuweb#1460 Bug: tint:677 Change-Id: If08cb450189c6158561051ef6e8f2439c60bc010 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/47140 Auto-Submit: Ben Clayton <bclayton@google.com> Kokoro: Kokoro <noreply+kokoro@google.com> Reviewed-by: David Neto <dneto@google.com> Commit-Queue: Ben Clayton <bclayton@google.com>
ben-clayton
added a commit
to ben-clayton/webgpu-samples
that referenced
this pull request
Jun 7, 2021
`void` was removed in gpuweb/gpuweb#1460
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1219
Closes #743
Basically, there is no utility right now for this type. It's obvious from looking at a function signature if a return statement is required, without the type.
If we ever feel that the type is needed, we can bring it back.