wgsl: Reserve vec and mat keywords
#1896
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also sort the keywords lexicographically. Fixes: gpuweb#1862
kvark
approved these changes
Jul 6, 2021
ben-clayton
added a commit
to ben-clayton/Tint
that referenced
this pull request
Jul 13, 2021
And add `vec` and `mat` to the reserved keyword list (see gpuweb/gpuweb#1896) Move these reserved keyword checks out of the lexer and into the parser. Generate a sensible error message. Add tests. Change-Id: I1876448201a2fd773f38f337b4e49bc61a7642f7 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/56545 Kokoro: Kokoro <noreply+kokoro@google.com> Reviewed-by: James Price <jrprice@google.com> Commit-Queue: Ben Clayton <bclayton@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also sort the keywords lexicographically.
Fixes: #1862