Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow unsigned wgsl array sizes. #1942

Merged
merged 1 commit into from
Jul 27, 2021
Merged

Allow unsigned wgsl array sizes. #1942

merged 1 commit into from
Jul 27, 2021

Conversation

kdashg
Copy link
Contributor

@kdashg kdashg commented Jul 14, 2021

No description provided.

@kdashg
Copy link
Contributor Author

kdashg commented Jul 14, 2021

Relevant to #1135.

@github-actions
Copy link
Contributor

Previews, as seen when this build job started (5f1459f):
WebGPU | IDL
WGSL
Explainer

@dneto0 dneto0 changed the title Allow unsized wgsl array sizes. Allow unsigned wgsl array sizes. Jul 14, 2021
@dneto0 dneto0 requested review from litherum and kvark July 14, 2021 19:03
@dneto0 dneto0 added the wgsl WebGPU Shading Language Issues label Jul 14, 2021
@dneto0 dneto0 added this to Open PRs in WGSL Jul 14, 2021
@dneto0 dneto0 added this to the MVP milestone Jul 14, 2021
@kdashg kdashg moved this from Open PRs to Needs Decision in WGSL Jul 14, 2021
@kvark
Copy link
Contributor

kvark commented Jul 14, 2021

This is also covered by #1792

@dneto0 dneto0 mentioned this pull request Jul 15, 2021
Closed
@dneto0
Copy link
Contributor

dneto0 commented Jul 27, 2021

Resolved in 2021-07-27 meeting to accept this PR.

#1792 has several other things in it as well, and will be treated separately.

@dneto0 dneto0 merged commit df4aa7f into gpuweb:main Jul 27, 2021
WGSL automation moved this from Needs Decision to Done Jul 27, 2021
github-actions bot added a commit that referenced this pull request Jul 27, 2021
@kdashg @github-actions
Allow unsized wgsl array sizes. (#1942)
146f1c9 
SHA: df4aa7f
Reason: push, by @dneto0

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot added a commit that referenced this pull request Jul 27, 2021
@kdashg @github-actions
Allow unsized wgsl array sizes. (#1942)
903cc0b 
SHA: df4aa7f
Reason: push, by @dneto0

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot added a commit that referenced this pull request Jul 27, 2021
@kdashg @github-actions
Allow unsized wgsl array sizes. (#1942)
0b37832 
SHA: df4aa7f
Reason: push, by @dneto0

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@kdashg kdashg mentioned this pull request Aug 9, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dneto0 dneto0 dneto0 approved these changes

@litherum litherum Awaiting requested review from litherum

@kvark kvark Awaiting requested review from kvark

Assignees
No one assigned
Labels
wgsl WebGPU Shading Language Issues
Projects
No open projects
WGSL
Done
Milestone
Milestone 0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kdashg @kvark @dneto0