Rename dispatch -> dispatchWorkgroups #2689
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kainino0x
approved these changes
Mar 28, 2022
kainino0x
added
the
tacit resolution queue
|
Landing due to lack of voiced concerns. |
kainino0x
removed
the
tacit resolution queue
aarongable
pushed a commit
to chromium/chromium
that referenced
this pull request
Apr 30, 2022
Dependent on https://dawn-review.googlesource.com/c/dawn/+/88364 In gpuweb/gpuweb#2689 both dispatch and dispatchIndirect were renamed to dispatchWorkgroups and dispatchWorkgroupsIndirect in order to clarify the meaning of the arguments. Bug: dawn:22 Change-Id: Iad26a9c6871cf6b6273e359a9b28d0f116957d5b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3614042 Reviewed-by: Austin Eng <enga@chromium.org> Reviewed-by: Kai Ninomiya <kainino@chromium.org> Commit-Queue: Brandon Jones <bajones@chromium.org> Cr-Commit-Position: refs/heads/main@{#998052}
mjfroman
pushed a commit
to mjfroman/moz-libwebrtc-third-party
that referenced
this pull request
Oct 14, 2022
Dependent on https://dawn-review.googlesource.com/c/dawn/+/88364 In gpuweb/gpuweb#2689 both dispatch and dispatchIndirect were renamed to dispatchWorkgroups and dispatchWorkgroupsIndirect in order to clarify the meaning of the arguments. Bug: dawn:22 Change-Id: Iad26a9c6871cf6b6273e359a9b28d0f116957d5b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3614042 Reviewed-by: Austin Eng <enga@chromium.org> Reviewed-by: Kai Ninomiya <kainino@chromium.org> Commit-Queue: Brandon Jones <bajones@chromium.org> Cr-Commit-Position: refs/heads/main@{#998052} NOKEYCHECK=True GitOrigin-RevId: 7c7a39eb1383713695ea0f73fa5a2c0665454d01
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2669
Given that there doesn't seem to be any outrage at the idea of renaming these methods, here's a spec PR to make it happen.
Also took the opportunity to clean up a little bit of formatting and move the note explaining the application of the workgroup counts into the
dispatchWorkgroups()algorithm description so that it's more easily noticed by anyone looking at the spec for reference.Preview | Diff