Rework WGSL grammar to make it nicer for recursive descent #3299
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributes to gpuweb#3286 1. Make certain productions amenable for recursive descent Avoid this kind of pattern: (x y) * x When you see a substring that would match 'x', you don't know if it should match the first or second 'x' in that phrase. Rewrite it something like this, to put the certain match against 'x' first. x (y x) * In particular, rewrite these rules: - struct_body_decl - argument_expression_list - param_list 2. Introduce additive_operator, multiplicative_operator This helps eliminate epsilons in the left-recursive form of the grammar 3. Create optionally_typed_ident, and use it to replace (ident | variable_ident_decl) pattern which became common because of type inferencing rules. Also expand last remaining use of variable_ident_decl, for formal parameter declaration.
|
Previews, as seen when this build job started (50aa755): |
alan-baker
reviewed
Aug 10, 2022
dj2
approved these changes
Aug 10, 2022
|
Previews, as seen when this build job started (0644866): |
alan-baker
approved these changes
Aug 10, 2022
jdarpinian
pushed a commit
to jdarpinian/gpuweb
that referenced
this pull request
Aug 12, 2022
* Rework WGSL grammar to make it nicer for recursive descent Contributes to gpuweb#3286 1. Make certain productions amenable for recursive descent Avoid this kind of pattern: (x y) * x When you see a substring that would match 'x', you don't know if it should match the first or second 'x' in that phrase. Rewrite it something like this, to put the certain match against 'x' first. x (y x) * In particular, rewrite these rules: - struct_body_decl - argument_expression_list - param_list 2. Introduce additive_operator, multiplicative_operator This helps eliminate epsilons in the left-recursive form of the grammar 3. Create optionally_typed_ident, and use it to replace (ident | variable_ident_decl) pattern which became common because of type inferencing rules. Also expand last remaining use of variable_ident_decl, for formal parameter declaration. * WGSL structs always have at least one member
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributes to #3286
Make certain productions amenable for recursive descent
Avoid this kind of pattern:
(x y) * x
When you see a substring that would match 'x', you don't know
if it should match the first or second 'x' in that phrase.
Rewrite it something like this, to put the certain match against 'x'
first.
x (y x) *
In particular, rewrite these rules:
This helps eliminate epsilons in the left-recursive form of the grammar
(ident | variable_ident_decl) pattern which became common
because of type inferencing rules.
Also expand last remaining use of variable_ident_decl, for formal
parameter declaration.