Add SharedWorker support #4465
Merged
Add SharedWorker support #4465
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Previews, as seen when this build job started (6f823ce): |
beaufortfrancois
force-pushed
the
worker
branch
from
751f3f6
to
d0464f5
Compare
beaufortfrancois
force-pushed
the
worker
branch
from
d0464f5
to
08f8203
Compare
kainino0x
approved these changes
Jan 26, 2024
kainino0x
reviewed
Jan 26, 2024
This was referenced Jan 29, 2024
aarongable
pushed a commit
to chromium/chromium
that referenced
this pull request
Jan 30, 2024
This CL adds shared worker support in WebGPU behind the WebGPUExperimentalFeatures experimental blink runtime feature. Intent to prototype: https://groups.google.com/a/chromium.org/g/blink-dev/c/t3V3J7a-lwc/m/TC6TUvGaAwAJ Spec PR: gpuweb/gpuweb#4465 Bug: 1521763 Change-Id: Ia8e36bb4cc87c656723c13fad653dc14fc3c3362 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5245685 Reviewed-by: Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by: Kentaro Hara <haraken@chromium.org> Commit-Queue: Fr <beaufort.francois@gmail.com> Reviewed-by: Kai Ninomiya <kainino@chromium.org> Cr-Commit-Position: refs/heads/main@{#1253916}
kainino0x
reviewed
Jan 31, 2024
|
PTAL just to verify we're good with both ServiceWorker and SharedWorker support. |
mwyrzykowski
approved these changes
Jan 31, 2024
jimblandy
approved these changes
Jan 31, 2024
|
@kainino0x @mwyrzykowski @jimblandy There's some activity in whatwg/html#10112 that requires our attention. Note that I still believe adding SharedWorker and ServiceWorker support to WebGPU is valuable. |
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following #4464 (comment), this PR adds SharedWorker support to the WebGPU spec.
See issue #4197